Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spanconfig: address fallout after enabling-by-default #75639

Closed
23 tasks done
irfansharif opened this issue Jan 28, 2022 · 1 comment
Closed
23 tasks done

spanconfig: address fallout after enabling-by-default #75639

irfansharif opened this issue Jan 28, 2022 · 1 comment
Labels
A-zone-configs C-test-failure Broken test (automatically or manually discovered).

Comments

@irfansharif
Copy link
Contributor

irfansharif commented Jan 28, 2022

Describe the problem

We recently enabled span configs by default: #73876. Given the blast radius, we expect it to non-trivial CI impact. This issue tracks (post-hoc) relevant flakes/investigations.

@irfansharif irfansharif added C-test-failure Broken test (automatically or manually discovered). A-zone-configs labels Jan 28, 2022
@irfansharif
Copy link
Contributor Author

irfansharif commented Jan 28, 2022

There are still a few outstanding tests, but looking at the build success rate from last week (the dip here was the fallout), I think we've addressed most of what we needed to to get back to pre-span config levels. We're not finding much in the way of real bugs in the infra, mostly just tests that need updating, so I'll stop combing for issues through TC/bors/etc. Closing.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-zone-configs C-test-failure Broken test (automatically or manually discovered).
Projects
None yet
Development

No branches or pull requests

2 participants