Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvserver: use MVCC range tombstones in DeleteRange #70415

Closed
erikgrinaker opened this issue Sep 20, 2021 · 2 comments · Fixed by #76203
Closed

kvserver: use MVCC range tombstones in DeleteRange #70415

erikgrinaker opened this issue Sep 20, 2021 · 2 comments · Fixed by #76203
Assignees
@erikgrinaker
Labels
A-kv-server Relating to the KV-level RPC server C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@erikgrinaker
Copy link
Contributor

erikgrinaker commented Sep 20, 2021 •
edited by cockroach-jira-scripts
Loading

In #70412, we will implement MVCC range deletion tombstones. Once available, the DeleteRange command should be updated to make use of this.

See also the (currently internal) design document.

Epic CRDB-2624

Jira issue: CRDB-10065
@erikgrinaker erikgrinaker added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-kv-server Relating to the KV-level RPC server T-kv KV Team labels Sep 20, 2021
This was referenced Sep 20, 2021
Closed
Closed
Closed
Closed
@ajwerner ajwerner mentioned this issue Nov 29, 2021
Closed
This was referenced Feb 5, 2022
Closed
Merged
Closed
@craig craig bot closed this as completed in 9c0d08d Feb 21, 2022
@erikgrinaker
Copy link
Contributor Author

This PR got reverted, we'll hold it for 22.2.

@erikgrinaker erikgrinaker reopened this Feb 23, 2022
@erikgrinaker erikgrinaker mentioned this issue Mar 14, 2022
Merged
@exalate-issue-sync exalate-issue-sync bot removed the T-kv KV Team label Jun 3, 2022
@erikgrinaker erikgrinaker mentioned this issue Jun 5, 2022
Closed
craig bot pushed a commit that referenced this issue Jun 9, 2022
@erikgrinaker
Merge #77762
4cced47 
77762: batcheval: add range tombstone support for `DeleteRange` r=aliher1911 a=erikgrinaker

This patch adds the parameter `UseExperimentalRangeTombstone` for
`DeleteRange`, which deletes the span using an MVCC range tombstone.
The new version gate `MVCCRangeTombstones` must be checked before using
it. `storage.ExperimentalMVCCDeleteRangeUsingTombstone()` is added to
carry out the actual deletion.

This is a bare-bones implementation to allow writing range keys via the
KV API for testing and development purposes. It has significant
shortcomings, and will be fleshed out at a later time.

Touches #70415.
Replaces #76203.

Release note: None

Co-authored-by: Erik Grinaker <[email protected]>
@erikgrinaker
Copy link
Contributor Author

This is essentially done, once we remove the experimental marker in #83772.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikgrinaker erikgrinaker

Labels
A-kv-server Relating to the KV-level RPC server C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

batcheval: add range tombstone support for DeleteRange erikgrinaker/cockroach
1 participant
@erikgrinaker