batcheval: add range tombstone support for DeleteRange
#76203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgrinaker
requested review from
dt,
ajwerner,
aliher1911 and
chengxiong-ruan
|
This change is |
Do you mean the iteration logic in the first commit? Please review that on the corresponding PR (#76131). |
aliher1911
suggested changes
Feb 10, 2022
erikgrinaker
force-pushed
the
delete-range-tombstone
branch
4 times, most recently
from
4a91b2b to
cde7141
Compare
erikgrinaker
force-pushed
the
delete-range-tombstone
branch
2 times, most recently
from
5b7ebf0 to
dac98d4
Compare
erikgrinaker
force-pushed
the
delete-range-tombstone
branch
from
dac98d4 to
2561d91
Compare
aliher1911
approved these changes
Feb 17, 2022
|
LGTM! |
dt
approved these changes
Feb 18, 2022
erikgrinaker
force-pushed
the
delete-range-tombstone
branch
2 times, most recently
from
b8e42d9 to
0ad9646
Compare
|
CI failure appears unrelated, Bazel build is still green. TFTRs! bors r=aliher1911,dt |
|
Merge conflict. |
|
Whoops, conflict with last bors r- |
This patch adds a parameter `UseExperimentalRangeTombstone` for `DeleteRange`, which deletes the span using an MVCC range tombstone. This must only be called after checking `storage.CanUseExperimentalMVCCRangeTombstones()`, which ensures the `ExperimentalMVCCRangeTombstones` version gate and `COCKROACH_EXPERIMENTAL_MVCC_RANGE_TOMBSTONES` environment variable are set. Did I mention that MVCC range tombstones are experimental? They are currently under active development, and are not respected by the KV or MVCC APIs, nor are they persisted. This patch simply sets up the plumbing for it. Release note: None
erikgrinaker
force-pushed
the
delete-range-tombstone
branch
from
0ad9646 to
f07cfd6
Compare
|
Trivial merge conflict, going to yolo this. bors r=aliher1911,dt |
|
Build succeeded: |
craig bot
pushed a commit
that referenced
this pull request
Feb 23, 2022
76921: storage: revert experimental MVCC range tombstones r=aliher1911 a=erikgrinaker This reverts most of #76131, #76203, and #76478 -- except minor changes that were unrelated to the range tombstones themselves. This leaves a gap for cluster version `Internal:78` -- I think that's probably fine, but I've left a comment. Co-authored-by: Erik Grinaker <[email protected]>
craig bot
pushed a commit
that referenced
this pull request
Jun 9, 2022
77762: batcheval: add range tombstone support for `DeleteRange` r=aliher1911 a=erikgrinaker This patch adds the parameter `UseExperimentalRangeTombstone` for `DeleteRange`, which deletes the span using an MVCC range tombstone. The new version gate `MVCCRangeTombstones` must be checked before using it. `storage.ExperimentalMVCCDeleteRangeUsingTombstone()` is added to carry out the actual deletion. This is a bare-bones implementation to allow writing range keys via the KV API for testing and development purposes. It has significant shortcomings, and will be fleshed out at a later time. Touches #70415. Replaces #76203. Release note: None Co-authored-by: Erik Grinaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a parameter
UseExperimentalRangeTombstoneforDeleteRange, which deletes the span using an MVCC range tombstone.This must only be called after checking
storage.CanUseExperimentalMVCCRangeTombstones(), which ensures theExperimentalMVCCRangeTombstonesversion gate andCOCKROACH_EXPERIMENTAL_MVCC_RANGE_TOMBSTONESenvironment variable areset.
Did I mention that MVCC range tombstones are experimental? They are
currently under active development, and are not respected by the KV or
MVCC APIs, nor are they persisted. This patch simply sets up the
plumbing for it.
Resolves #70415.
Touches #70427.
Release note: None