Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: remove experimental markers for MVCC range tombstones #83772

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Jul 4, 2022

GC is still under development, but I think it's fine to remove the marker before GC works to let people start building with it.


This removes the experimental markers for MVCC range tombstones, by
renaming functions, methods, and parameters to not include
experimental, as well as warning comments.

The changes are entirely mechanical.

Release note: None

@erikgrinaker erikgrinaker requested review from a team as code owners July 4, 2022 13:10
@erikgrinaker erikgrinaker self-assigned this Jul 4, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@aliher1911 aliher1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

This removes the experimental markers for MVCC range tombstones, by
renaming functions, methods, and parameters to not include
`experimental`, and removing warning comments.

The changes are entirely mechanical.

Release note: None
@erikgrinaker erikgrinaker force-pushed the mvcc-range-tombstones-remove-experimental branch from 2592218 to 1fb3c64 Compare July 5, 2022 12:51
@erikgrinaker
Copy link
Contributor Author

erikgrinaker commented Jul 5, 2022

@jbowens I see we're still using the Experimental() API on e.g. Pebble batches. Are we keeping this experimental for now in Pebble?

@erikgrinaker
Copy link
Contributor Author

bors r=aliher1911

@craig
Copy link
Contributor

craig bot commented Jul 5, 2022

Build succeeded:

@craig craig bot merged commit 97f8422 into cockroachdb:master Jul 5, 2022
@erikgrinaker erikgrinaker deleted the mvcc-range-tombstones-remove-experimental branch July 12, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants