Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvserver: emit MVCC range tombstones across rangefeeds #82449

Closed
erikgrinaker opened this issue Jun 5, 2022 · 1 comment · Fixed by #82718
Closed

kvserver: emit MVCC range tombstones across rangefeeds #82449

erikgrinaker opened this issue Jun 5, 2022 · 1 comment · Fixed by #82718
Assignees
@erikgrinaker
Labels
A-kv-replication Relating to Raft, consensus, and coordination. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@erikgrinaker
Copy link
Contributor

erikgrinaker commented Jun 5, 2022 •
edited by cockroach-jira-scripts
Loading

Once MVCC range tombstones are implemented in #70412, and used in DeleteRange in #70415, they should be emitted across rangefeeds. These will be recorded as a new MVCCDeleteRangeOpType logical op type, and emitted as a new RangeFeedDeleteRange rangefeed event. These will be emitted whenever DeleteRange is called with the UseExperimentalRangeTombstone parameter, and also during catchup scans, but not during initial scans (which never emit tombstones).

Epic CRDB-2624

Jira issue: CRDB-16401
@erikgrinaker erikgrinaker added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-kv-replication Relating to Raft, consensus, and coordination. T-kv-replication labels Jun 5, 2022
@erikgrinaker erikgrinaker self-assigned this Jun 5, 2022
@blathers-crl
Copy link

blathers-crl bot commented Jun 5, 2022

cc @cockroachdb/replication

This was referenced Jun 5, 2022
Closed
Closed
Merged
@erikgrinaker erikgrinaker mentioned this issue Jun 15, 2022
Closed
@craig craig bot closed this as completed in #82718 Jun 28, 2022
@craig craig bot closed this as completed in 5541cf8 Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikgrinaker erikgrinaker

Labels
A-kv-replication Relating to Raft, consensus, and coordination. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kvserver: emit MVCC range tombstones over rangefeeds erikgrinaker/cockroach
1 participant
@erikgrinaker