Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/stats: TestCacheWait failed #51712

Closed
cockroach-teamcity opened this issue Jul 22, 2020 · 3 comments · Fixed by #51828
Closed

sql/stats: TestCacheWait failed #51712

cockroach-teamcity opened this issue Jul 22, 2020 · 3 comments · Fixed by #51828
Assignees
@rytaft
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Milestone
20.2

Comments

@cockroach-teamcity
Copy link
Member

(sql/stats).TestCacheWait failed on master@e9a4f83e3eee59510f97db2c6e0df9b57cf6b944:

=== RUN   TestCacheWait
    TestCacheWait: test_log_scope.go:77: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestCacheWait155972359
    TestCacheWait: test_log_scope.go:58: use -show-logs to present logs inline
    TestCacheWait: stats_cache_test.go:403: expected 1 query, got 0
test logs left over in: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestCacheWait155972359
--- FAIL: TestCacheWait (0.12s)
More

Parameters:

  • TAGS=
  • GOFLAGS=-parallel=4
make stressrace TESTS=TestCacheWait PKG=./pkg/sql/stats TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Jul 22, 2020
@cockroach-teamcity cockroach-teamcity added this to the 20.2 milestone Jul 22, 2020
@cockroach-teamcity
Copy link
Member Author

(sql/stats).TestCacheWait failed on master@e9a4f83e3eee59510f97db2c6e0df9b57cf6b944:

=== RUN   TestCacheWait
    TestCacheWait: test_log_scope.go:77: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestCacheWait531024767
    TestCacheWait: test_log_scope.go:58: use -show-logs to present logs inline
    TestCacheWait: stats_cache_test.go:403: expected 1 query, got 0
test logs left over in: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestCacheWait531024767
    TestCacheWait: testing.go:906: race detected during execution of test
--- FAIL: TestCacheWait (0.84s)
More

Parameters:

  • TAGS=
  • GOFLAGS=-race -parallel=2
make stressrace TESTS=TestCacheWait PKG=./pkg/sql/stats TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

@RaduBerinde RaduBerinde assigned rytaft and unassigned RaduBerinde Jul 22, 2020
@cockroach-teamcity
Copy link
Member Author

(sql/stats).TestCacheWait failed on master@b8a50cc4d062293915969cdc83e3ec4d057cede5:

=== RUN   TestCacheWait
    TestCacheWait: test_log_scope.go:77: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestCacheWait062935031
    TestCacheWait: test_log_scope.go:58: use -show-logs to present logs inline
    TestCacheWait: stats_cache_test.go:403: expected 1 query, got 0
test logs left over in: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestCacheWait062935031
--- FAIL: TestCacheWait (0.20s)
More

Parameters:

  • TAGS=
  • GOFLAGS=-parallel=4
make stressrace TESTS=TestCacheWait PKG=./pkg/sql/stats TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity
Copy link
Member Author

(sql/stats).TestCacheWait failed on master@b8a50cc4d062293915969cdc83e3ec4d057cede5:

=== RUN   TestCacheWait
    TestCacheWait: test_log_scope.go:77: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestCacheWait829252559
    TestCacheWait: test_log_scope.go:58: use -show-logs to present logs inline
    TestCacheWait: stats_cache_test.go:403: expected 1 query, got 0
test logs left over in: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestCacheWait829252559
    TestCacheWait: testing.go:906: race detected during execution of test
--- FAIL: TestCacheWait (0.94s)
More

Parameters:

  • TAGS=
  • GOFLAGS=-race -parallel=2
make stressrace TESTS=TestCacheWait PKG=./pkg/sql/stats TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

@rytaft rytaft mentioned this issue Jul 23, 2020
Merged
craig bot pushed a commit that referenced this issue Jul 23, 2020
@rohany @rytaft @RaduBerinde
Merge #51621 #51828 #51837
fb77854 
51621: descs: push descriptor type hydration into the desc.Collection r=rohany a=rohany

Fixes #49484.
Preparation for #51385.

Up until now, the `planner` was responsible for installing user defined
type metadata in tables that contained user defined types. This was
slightly messy and caused leakage of responsibility regarding when
descriptors had user defined types vs when they didn't. This commit
pushes that responsibility into the `descs.Collection`. It also paves
the way for work to avoid copying `ImmutableTableDescriptor`s that
contain user defined types every time that they need hydration.

Release note: None

51828: sql,stats: fix flakes in TestCacheWait and TestQueryCache r=jordanlewis a=rytaft

**stats: fix flake in TestCacheWait**

This commit fixes a flake in `TestCacheWait`, which was introduced
by #51616. That PR changed the call to `InvalidateTableStats` in
`TestCacheWait` to `RefreshTableStats`, but that change should not have
been made. The purpose of the test is to test that the cache invalidation
and waiting mechanisms work correctly, and therefore it must call
`InvalidateTableStats`, not `RefreshTableStats`.

Fixes #51712

**sql: fix flake in TestQueryCache/group/statschange**

This commit fixes a flake in TestQueryCache/group/statschange,
which was introduced by #51616. That PR made updates to the stats
cache asynchronous, so we can no longer expect the query cache to
be invalidated immediately after a stats update. This commit fixes
the problem by introducing a retry mechanism into the test.

Fixes #51693

51837: sql: don't show the "hidden" column flag in EXPLAIN r=RaduBerinde a=RaduBerinde

The ResultColumns.Hidden flag is used internally; it does not carry
useful information for users and should not be visible in EXPLAIN.

Release note (sql change): EXPLAIN no longer shows the "hidden"
annotation for columns.

Co-authored-by: Rohan Yadav <[email protected]>
Co-authored-by: Rebecca Taft <[email protected]>
Co-authored-by: Radu Berinde <[email protected]>
@craig craig bot closed this as completed in 2c6bcd9 Jul 23, 2020
rytaft added a commit to rytaft/cockroach that referenced this issue Jul 31, 2020
@rytaft
stats: fix flake in TestCacheWait
6ce476d 
This commit fixes a flake in TestCacheWait, which was introduced
by cockroachdb#51616. That PR changed the call to InvalidateTableStats in
TestCacheWait to RefreshTableStats, but that change should not have
been made. The purpose of the test is to test that the cache invalidation
and waiting mechanisms work correctly, and therefore it must call
InvalidateTableStats, not RefreshTableStats.

Fixes cockroachdb#51712

Release note: None
rytaft added a commit to rytaft/cockroach that referenced this issue Jul 31, 2020
@rytaft
stats: fix flake in TestCacheWait
96e9255 
This commit fixes a flake in TestCacheWait, which was introduced
by cockroachdb#51616. That PR changed the call to InvalidateTableStats in
TestCacheWait to RefreshTableStats, but that change should not have
been made. The purpose of the test is to test that the cache invalidation
and waiting mechanisms work correctly, and therefore it must call
InvalidateTableStats, not RefreshTableStats.

Fixes cockroachdb#51712

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rytaft rytaft

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
20.2
Development

Successfully merging a pull request may close this issue.

sql,stats: fix flakes in TestCacheWait and TestQueryCache rytaft/cockroach
3 participants
@rytaft @RaduBerinde @cockroach-teamcity