Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: TestQueryCache failed #51693

Closed
cockroach-teamcity opened this issue Jul 22, 2020 · 3 comments · Fixed by #51828
Closed

sql: TestQueryCache failed #51693

cockroach-teamcity opened this issue Jul 22, 2020 · 3 comments · Fixed by #51828
Assignees
@rytaft
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Milestone
20.2

Comments

@cockroach-teamcity
Copy link
Member

(sql).TestQueryCache failed on master@e9a4f83e3eee59510f97db2c6e0df9b57cf6b944:

=== RUN   TestQueryCache
    TestQueryCache: test_log_scope.go:77: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestQueryCache740951531
    TestQueryCache: test_log_scope.go:58: use -show-logs to present logs inline
--- FAIL: TestQueryCache (2.93s)
=== RUN   TestQueryCache/group/statschange
=== PAUSE TestQueryCache/group/statschange
=== CONT  TestQueryCache/group/statschange
        --- FAIL: TestQueryCache/group/statschange (1.18s)
=== RUN   TestQueryCache/group
    --- FAIL: TestQueryCache/group (0.00s)
More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestQueryCache PKG=./pkg/sql TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Jul 22, 2020
@cockroach-teamcity cockroach-teamcity added this to the 20.2 milestone Jul 22, 2020
@cockroach-teamcity
Copy link
Member Author

(sql).TestQueryCache failed on master@e9a4f83e3eee59510f97db2c6e0df9b57cf6b944:

=== RUN   TestQueryCache
    TestQueryCache: test_log_scope.go:77: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestQueryCache343816065
    TestQueryCache: test_log_scope.go:58: use -show-logs to present logs inline
--- FAIL: TestQueryCache (1.16s)
=== RUN   TestQueryCache/group/statschange
=== PAUSE TestQueryCache/group/statschange
=== CONT  TestQueryCache/group/statschange
        --- FAIL: TestQueryCache/group/statschange (0.31s)
=== RUN   TestQueryCache/group
    --- FAIL: TestQueryCache/group (0.00s)
More

Parameters:

  • TAGS=
  • GOFLAGS=-parallel=4
make stressrace TESTS=TestQueryCache PKG=./pkg/sql TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

@RaduBerinde RaduBerinde assigned rytaft and unassigned RaduBerinde Jul 22, 2020
@andreimatei
Copy link
Contributor

ran into this too

@cockroach-teamcity
Copy link
Member Author

(sql).TestQueryCache failed on master@b8a50cc4d062293915969cdc83e3ec4d057cede5:

=== RUN   TestQueryCache
    TestQueryCache: test_log_scope.go:77: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestQueryCache485450181
    TestQueryCache: test_log_scope.go:58: use -show-logs to present logs inline
--- FAIL: TestQueryCache (1.89s)
=== RUN   TestQueryCache/group/statschange
=== PAUSE TestQueryCache/group/statschange
=== CONT  TestQueryCache/group/statschange
        --- FAIL: TestQueryCache/group/statschange (0.60s)
=== RUN   TestQueryCache/group
    --- FAIL: TestQueryCache/group (0.00s)
More

Parameters:

  • TAGS=
  • GOFLAGS=-parallel=4
make stressrace TESTS=TestQueryCache PKG=./pkg/sql TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

@rytaft rytaft mentioned this issue Jul 23, 2020
Merged
craig bot pushed a commit that referenced this issue Jul 23, 2020
@rohany @rytaft @RaduBerinde
Merge #51621 #51828 #51837
fb77854 
51621: descs: push descriptor type hydration into the desc.Collection r=rohany a=rohany

Fixes #49484.
Preparation for #51385.

Up until now, the `planner` was responsible for installing user defined
type metadata in tables that contained user defined types. This was
slightly messy and caused leakage of responsibility regarding when
descriptors had user defined types vs when they didn't. This commit
pushes that responsibility into the `descs.Collection`. It also paves
the way for work to avoid copying `ImmutableTableDescriptor`s that
contain user defined types every time that they need hydration.

Release note: None

51828: sql,stats: fix flakes in TestCacheWait and TestQueryCache r=jordanlewis a=rytaft

**stats: fix flake in TestCacheWait**

This commit fixes a flake in `TestCacheWait`, which was introduced
by #51616. That PR changed the call to `InvalidateTableStats` in
`TestCacheWait` to `RefreshTableStats`, but that change should not have
been made. The purpose of the test is to test that the cache invalidation
and waiting mechanisms work correctly, and therefore it must call
`InvalidateTableStats`, not `RefreshTableStats`.

Fixes #51712

**sql: fix flake in TestQueryCache/group/statschange**

This commit fixes a flake in TestQueryCache/group/statschange,
which was introduced by #51616. That PR made updates to the stats
cache asynchronous, so we can no longer expect the query cache to
be invalidated immediately after a stats update. This commit fixes
the problem by introducing a retry mechanism into the test.

Fixes #51693

51837: sql: don't show the "hidden" column flag in EXPLAIN r=RaduBerinde a=RaduBerinde

The ResultColumns.Hidden flag is used internally; it does not carry
useful information for users and should not be visible in EXPLAIN.

Release note (sql change): EXPLAIN no longer shows the "hidden"
annotation for columns.

Co-authored-by: Rohan Yadav <[email protected]>
Co-authored-by: Rebecca Taft <[email protected]>
Co-authored-by: Radu Berinde <[email protected]>
@craig craig bot closed this as completed in 1bb2a55 Jul 23, 2020
@irfansharif irfansharif mentioned this issue Jul 23, 2020
Merged
rytaft added a commit to rytaft/cockroach that referenced this issue Jul 31, 2020
@rytaft
sql: fix flake in TestQueryCache/group/statschange
849c181 
This commit fixes a flake in TestQueryCache/group/statschange,
which was introduced by cockroachdb#51616. That PR made updates to the stats
cache asynchronous, so we can no longer expect the query cache to
be invalidated immediately after a stats update. This commit fixes
the problem by introducing a retry mechanism into the test.

Fixes cockroachdb#51693

Release note: None
rytaft added a commit to rytaft/cockroach that referenced this issue Jul 31, 2020
@rytaft
sql: fix flake in TestQueryCache/group/statschange
d8ad6a8 
This commit fixes a flake in TestQueryCache/group/statschange,
which was introduced by cockroachdb#51616. That PR made updates to the stats
cache asynchronous, so we can no longer expect the query cache to
be invalidated immediately after a stats update. This commit fixes
the problem by introducing a retry mechanism into the test.

Fixes cockroachdb#51693

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rytaft rytaft

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
20.2
Development

Successfully merging a pull request may close this issue.

sql,stats: fix flakes in TestCacheWait and TestQueryCache rytaft/cockroach
4 participants
@andreimatei @rytaft @RaduBerinde @cockroach-teamcity