sql,stats: fix flakes in TestCacheWait and TestQueryCache #51828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a flake in TestCacheWait, which was introduced by cockroachdb#51616. That PR changed the call to InvalidateTableStats in TestCacheWait to RefreshTableStats, but that change should not have been made. The purpose of the test is to test that the cache invalidation and waiting mechanisms work correctly, and therefore it must call InvalidateTableStats, not RefreshTableStats. Fixes cockroachdb#51712 Release note: None
|
This change is |
rytaft
changed the title
rytaft
changed the title
This commit fixes a flake in TestQueryCache/group/statschange, which was introduced by cockroachdb#51616. That PR made updates to the stats cache asynchronous, so we can no longer expect the query cache to be invalidated immediately after a stats update. This commit fixes the problem by introducing a retry mechanism into the test. Fixes cockroachdb#51693 Release note: None
RaduBerinde
approved these changes
Jul 23, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
|
TFTR! bors r+ |
|
Build failed: |
|
Courtesy re-bors due to flake in version-upgrade: bors r+ |
|
Build succeeded: |
This was referenced Jul 31, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stats: fix flake in TestCacheWait
This commit fixes a flake in
TestCacheWait, which was introducedby #51616. That PR changed the call to
InvalidateTableStatsinTestCacheWaittoRefreshTableStats, but that change should not havebeen made. The purpose of the test is to test that the cache invalidation
and waiting mechanisms work correctly, and therefore it must call
InvalidateTableStats, notRefreshTableStats.Fixes #51712
sql: fix flake in TestQueryCache/group/statschange
This commit fixes a flake in TestQueryCache/group/statschange,
which was introduced by #51616. That PR made updates to the stats
cache asynchronous, so we can no longer expect the query cache to
be invalidated immediately after a stats update. This commit fixes
the problem by introducing a retry mechanism into the test.
Fixes #51693