sql: don't show the "hidden" column flag in EXPLAIN #51837
Conversation
The ResultColumns.Hidden flag is used internally; it does not carry useful information for users and should not be visible in EXPLAIN. Release note (sql change): EXPLAIN no longer shows the "hidden" annotation for columns.
|
This change is |
There was a problem hiding this comment.
Reviewed 11 of 12 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde and @yuzefovich)
pkg/sql/sqlbase/result_columns.go, line 108 at r1 (raw file):
// The column types are printed if printTypes is true. // The hidden property is printed if showHidden is true. func (r ResultColumns) String(printTypes bool, showHidden bool) string {
You planning on passing showHidden=true elsewhere? I only see the one call passing false.
There was a problem hiding this comment.
Reviewable status:
|
pkg/sql/sqlbase/result_columns.go, line 108 at r1 (raw file): Previously, mgartner (Marcus Gartner) wrote…
No, there's no other caller. Just wanted to keep it general. |
There was a problem hiding this comment.
bors r+
Reviewable status:
|
Build succeeded: |
The ResultColumns.Hidden flag is used internally; it does not carry
useful information for users and should not be visible in EXPLAIN.
Release note (sql change): EXPLAIN no longer shows the "hidden"
annotation for columns.