MarkdownBear doesn't work anymore #1235

coala-bot · 2017-01-01T15:32:31Z

It always wants to empty all my files, something's horribly wrong here.

This issue was found by @nutella25 and I can reproduce it.

type bug importance critical needs backport

sils · 2017-01-01T20:12:24Z

my fault, wrong remark installed... we have to do something against this.

jayvdb · 2017-01-02T01:26:35Z

Yea, the docker is broken for MarkdownBear : https://travis-ci.org/jayvdb/docker-coala-base/builds/188134615#L9730 . The cause is >= syntax in package.json.
I'm testing a fix.
The simple workaround is to edit the .travis.yml to add npm install -g remark-lint

jayvdb · 2017-01-02T01:41:35Z

An easier workaround is to replace coala/base (which defaults to coala/base:latest) with coala/base:0.9 which uses the released version, which shouldnt have this bug.

Install npm packages locally and add the local binaries to the PATH. Fixes coala/coala-bears#1235

sils · 2017-01-02T05:18:50Z

the latest docker version should be the same as 0.9, I always trigger both when I rebuild the release and since latest is pulled by default it shouldn't be the prerelease, right?

Install npm packages locally and add the local binaries to the PATH. Fixes coala/coala-bears#1235

jayvdb · 2017-01-04T03:50:53Z

the latest docker version should be the same as 0.9, ..

unfortunately this issue doesnt include a travis log to confirm which image was broken.

I tested in 0.9 again, and it worked: https://travis-ci.org/jayvdb/sails-docs/builds/188711823

jayvdb · 2017-01-04T11:06:21Z

See also #926

sils · 2017-01-04T11:51:07Z

CC @namanyadav12 we think your code may have broken this bear.

sils · 2017-01-04T11:53:17Z

So we may want to try reverting 57dbcc4

namanyadav12 · 2017-01-04T15:48:34Z

Oh sorry for the troubled caused.
Although what seems to be the problem. Is it because i used >= in package.json

namanyadav12 · 2017-01-04T16:17:04Z

Will the problem solve if I change "remark-lint": ">=5.1.0" to "remark-lint": "~5.1.0"

jayvdb · 2017-01-04T17:59:52Z

Will the problem solve if I change "remark-lint": ">=5.1.0" to "remark-lint": "~5.1.0"

No. That was a problem with the docker.
I suggest you add more unit tests, and not use good files and bad files; instead, inspect the returned values to ensure they are exactly what they should be.

namanyadav12 · 2017-01-04T18:37:59Z

Ok

jayvdb · 2017-01-09T23:19:50Z

@namanyadav12 , your last message here was 5 days ago. You have been working on #1277 instead, which is quite distressing. This bug is the most critical problem in the pre-release.

Can you get this bear working correctly? promptly?
If not, we need to revert #1204 so we get back to a happy place.

Also added a better test to check the exact message of the result. Fixes coala#1235

namanyadav12 · 2017-01-10T05:00:30Z

@jayvdb i thought you said that was a problem with the docker.
And MarkdownBear always worked fine on my laptop and i wasn't able to reproduce the error .
I have created a pr #1280 with another test which checks the exact message as requested.

jayvdb · 2017-03-08T08:14:37Z

https://travis-ci.org/jayvdb/discourse_docker/builds/208883544 is a build using the 0.10 docker image; the markdown files are wiped out.

jayvdb · 2017-03-22T15:43:17Z

Another example, in our own backyard : https://gitlab.com/yuki_is_bored/cobot/builds/12258827

jayvdb · 2017-04-18T06:19:00Z

I've confirmed in many different ways that the problem is in remark, and maybe isolated to specific versions (of node stuff?) in the docker image.

It can be reproduced by moving out of the coala-bears directory and using MarkdownBear, or remark with remark-line.
e.g.
https://travis-ci.org/jayvdb/coala/jobs/223015470#L802
and
https://travis-ci.org/jayvdb/docker-coala-base/builds/223013298
and
https://travis-ci.org/jayvdb/coala-bears/jobs/223038041#L3226

remark-cli needs to find its plugins. When invoked in `/coala-bears` directory, Node automatically looks in `node_modules`. However if the docker image is used normally the working directory will not be `/coala-bears`. Setting NODE_PATH ensures that the plugins can be found. Related to coala/coala-bears#1235

jayvdb · 2017-04-20T17:24:10Z

So it is important to note that this can be fixed by the person who has installed the bear dependencies.
We should rel-note that in 0.10.2

Ideally we also raise a bug upstream, and/or try to workaround the problem in the bear, probably for 0.10.3.

jayvdb · 2017-04-20T17:28:48Z

Worth noting ... the docker .travis.yml now has a test for this.

And before we raise an upstream bug, using an old version of remark, we need to create a demo repo so it shows the problem clearly, and hopefully remark authors can easily see a fix. If we dont make it easy, they will close the bug and tell us to upgrade to the latest version of remark.

remark-cli needs to find its plugins. When invoked in `/coala-bears` directory, Node automatically looks in `node_modules`. However if the docker image is used normally the working directory will not be `/coala-bears`. Setting NODE_PATH ensures that the plugins can be found. Related to coala/coala-bears#1235

jayvdb · 2017-04-20T18:48:56Z

We could anchor a release note on #1630 , if that is merged and backported to 10.2.

meetmangukiya · 2017-04-23T07:08:38Z

We are having a new release soon, still backport needed?

A better test for MarkdownBear to check the exact message of the result for a maximum line length error. Related to coala#1235

gitmate-bot added needs backport type/bug labels Jan 1, 2017

sils closed this as completed Jan 1, 2017

jayvdb reopened this Jan 2, 2017

jayvdb added a commit to jayvdb/docker-coala-base that referenced this issue Jan 2, 2017

Properly support NPM package.json

5bc582a

Install npm packages locally and add the local binaries to the PATH. Fixes coala/coala-bears#1235

jayvdb mentioned this issue Jan 2, 2017

Properly support NPM package.json coala/docker-coala-base#68

Merged

jayvdb added a commit to jayvdb/docker-coala-base that referenced this issue Jan 2, 2017

Properly support NPM package.json

86ae323

Install npm packages locally and add the local binaries to the PATH. Fixes coala/coala-bears#1235

rultor closed this as completed in coala/docker-coala-base#68 Jan 2, 2017

jayvdb reopened this Jan 4, 2017

jayvdb mentioned this issue Jan 4, 2017

MarkdownBear: Add setting to enforce maximum line length #1204

Merged

jayvdb added this to the 0.10 milestone Jan 4, 2017

jayvdb mentioned this issue Jan 4, 2017

MarkdownBear: Line length is not being enforced #1181

Closed

sils added the importance/high label Jan 4, 2017

jayvdb mentioned this issue Jan 9, 2017

MarkdownBear: Add remark-validate-links plugin #1277

Closed

namanyadav12 added a commit to namanyadav12/coala-bears that referenced this issue Jan 10, 2017

MarkdownBear: Fix MarkdownBear

4b24fc5

Also added a better test to check the exact message of the result. Fixes coala#1235

namanyadav12 mentioned this issue Jan 10, 2017

MarkdownBear: Add test to check message for error #1280

Merged

Mixih modified the milestones: 0.11, 0.10 Feb 24, 2017

jayvdb mentioned this issue Mar 14, 2017

Release coala 0.10 image coala/docker-coala-base#125

Closed

meetmangukiya mentioned this issue Mar 25, 2017

Markdownbear isn't working as intended #1542

Closed

jayvdb mentioned this issue Apr 18, 2017

MarkdownBear should only use lint= if max_line_length is set #1581

Closed

This was referenced Apr 18, 2017

MarkdownBear: Set NODE_PATH for remark-lint coala/docker-coala-base#159

Merged

generate_package.py: Run in bears parent directory #1605

Merged

jayvdb modified the milestones: 0.10.3, 0.11 Apr 20, 2017

jayvdb modified the milestones: 0.10.2, 0.10.3 Apr 20, 2017

gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017

MarkdownBear: Add test to check message for error

a213020

A better test for MarkdownBear to check the exact message of the result for a maximum line length error. Related to coala#1235

gitmate-bot added the status/STALE label Sep 1, 2017

Makman2 removed the status/STALE label Mar 30, 2018

This was referenced May 8, 2018

MarkdownBear: Not outputting the correct output #2131

Closed

Add MarkdownBear and format existing .md coala/cEPs#128

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MarkdownBear doesn't work anymore #1235

MarkdownBear doesn't work anymore #1235

coala-bot commented Jan 1, 2017

sils commented Jan 1, 2017

jayvdb commented Jan 2, 2017

jayvdb commented Jan 2, 2017 •

edited

Loading

sils commented Jan 2, 2017

jayvdb commented Jan 4, 2017

jayvdb commented Jan 4, 2017

sils commented Jan 4, 2017

sils commented Jan 4, 2017

namanyadav12 commented Jan 4, 2017 •

edited

Loading

namanyadav12 commented Jan 4, 2017

jayvdb commented Jan 4, 2017

namanyadav12 commented Jan 4, 2017

jayvdb commented Jan 9, 2017

namanyadav12 commented Jan 10, 2017 •

edited

Loading

jayvdb commented Mar 8, 2017

jayvdb commented Mar 22, 2017

jayvdb commented Apr 18, 2017 •

edited

Loading

jayvdb commented Apr 20, 2017

jayvdb commented Apr 20, 2017

jayvdb commented Apr 20, 2017

meetmangukiya commented Apr 23, 2017

MarkdownBear doesn't work anymore #1235

MarkdownBear doesn't work anymore #1235

Comments

coala-bot commented Jan 1, 2017

sils commented Jan 1, 2017

jayvdb commented Jan 2, 2017

jayvdb commented Jan 2, 2017 • edited Loading

sils commented Jan 2, 2017

jayvdb commented Jan 4, 2017

jayvdb commented Jan 4, 2017

sils commented Jan 4, 2017

sils commented Jan 4, 2017

namanyadav12 commented Jan 4, 2017 • edited Loading

namanyadav12 commented Jan 4, 2017

jayvdb commented Jan 4, 2017

namanyadav12 commented Jan 4, 2017

jayvdb commented Jan 9, 2017

namanyadav12 commented Jan 10, 2017 • edited Loading

jayvdb commented Mar 8, 2017

jayvdb commented Mar 22, 2017

jayvdb commented Apr 18, 2017 • edited Loading

jayvdb commented Apr 20, 2017

jayvdb commented Apr 20, 2017

jayvdb commented Apr 20, 2017

meetmangukiya commented Apr 23, 2017

jayvdb commented Jan 2, 2017 •

edited

Loading

namanyadav12 commented Jan 4, 2017 •

edited

Loading

namanyadav12 commented Jan 10, 2017 •

edited

Loading

jayvdb commented Apr 18, 2017 •

edited

Loading