Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MarkdownBear: Add remark-validate-links plugin #1277

Closed
wants to merge 1 commit into from
Closed

MarkdownBear: Add remark-validate-links plugin #1277

wants to merge 1 commit into from

Conversation

namanyadav12
Copy link
Contributor

Remark plugin to validate if links to headings and files in markdown point to existing things.

Closes #924

@gitmate-bot
Copy link
Collaborator

Thanks for your contribution!

Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.

As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!

@gitmate-bot
Copy link
Collaborator

Comment on 53e804e.

Body of HEAD commit contains too long lines. Commit body lines should not exceed 72 characters.

GitCommitBear, severity NORMAL, section commit.

@namanyadav12 namanyadav12 force-pushed the markdown_remark-validate-links branch 2 times, most recently from 113efe2 to cc7b7ce Compare January 8, 2017 18:45
aptrishu
aptrishu reviewed Jan 8, 2017
View reviewed changes
tests/markdown/MarkdownBearTest.py
self.uut = MarkdownBear(Section('name'), Queue())

def test_validate_links_message(self):
content = test_file4.splitlines()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check test_file5 also..

Copy link
Contributor Author

@namanyadav12 namanyadav12 Jan 9, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am already checking it in the MarkdownValidateLinksTest, this is to check if the message of the result for an invalid file is correct.

@namanyadav12 namanyadav12 force-pushed the markdown_remark-validate-links branch from cc7b7ce to a0b814e Compare January 9, 2017 14:26
@namanyadav12
MarkdownBear: Add remark-validate-links plugin
506c35e 
Remark plugin to validate if links to headings and
files in markdown point to existing things.

Closes coala#924
@namanyadav12 namanyadav12 force-pushed the markdown_remark-validate-links branch from a0b814e to 506c35e Compare January 9, 2017 19:14
@jayvdb jayvdb mentioned this pull request Jan 9, 2017
Open
@jayvdb
Copy link
Member

jayvdb commented Jan 9, 2017

The bear is broken. Enhancing the bear now is not an option. It needs to be fixed first: #1235

@jayvdb jayvdb closed this Jan 9, 2017
@namanyadav12 namanyadav12 mentioned this pull request Jan 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aptrishu aptrishu aptrishu left review comments

Assignees
No one assigned
Labels
process/pending review review carefully! size/M
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@namanyadav12 @gitmate-bot @jayvdb @aptrishu