MarkdownBear: Add test to check message for error #1280

namanyadav12 · 2017-01-10T04:46:45Z

A better test for MarkdownBear to check the exact message
of the result for a maximum line length error.

Related to #1235

gitmate-bot · 2017-01-10T04:47:00Z

Thanks for your contribution!

Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.

I have rebased properly. Please see this for a tutorial.
I have gone through the commit guidelines and I've followed them:
I have followed the guidelines for the commit shortlog.
I have followed the guidelines for the commit body.
I have included the issue URL.
I have used the Fixes keyword if the commit fixes a real bug and the Closes keyword if it adds a feature/enhancement. See more here.
I have run all the tests and they all pass. That includes that all CI (below) is green - if GitMate issues appear you will have to amend your commits, pushing new commits on top is not sufficient!

As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!

sils · 2017-01-10T08:51:54Z

tests/markdown/MarkdownBearTest.py

+            with execute_bear(self.uut, fname, file) as results:
+                self.assertEqual(results[0].message,
+                                 'Line must be at most 10 characters'
+                                 '  maximum-line-length  remark-lint')


hm the spacing is a bit weird, why is this ' maximum-line-length remark-lint' included in the message anyway?

Yup,I actually improved the output_regex and the removed the 'maximum-line-length remark-lint' in #1277 but that pr is on hold till this issue is resolved.

sils · 2017-01-10T08:52:31Z

since you haven't actually done a bugfix but rather prove that there is no bug I'd use closes, not fixes. Also commit message should sum up the change, let's try something like MarkdownBear: Add test for message or so.

The code change looks rather good and we have to rethink where our docker image bug could be... :/

sils · 2017-01-10T11:53:41Z

👍

gitmate-bot · 2017-01-10T15:06:18Z

Comment on 7abd34b.

Shortlog of the HEAD commit contains 65 character(s). This is 15 character(s) longer than the limit (65 > 50).

GitCommitBear, severity NORMAL, section commit.

fneu · 2017-01-11T21:39:10Z

ack f1a0a25

fneu · 2017-01-11T21:39:21Z

@rultor merge

rultor · 2017-01-11T21:40:13Z

@rultor merge

@fneu OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2017-01-11T21:41:43Z

@rultor merge

@fneu @namanyadav12 Oops, I failed. You can see the full log here (spent 1min)

+ git remote update
Fetching origin
Fetching fork
From github.com:namanyadav12/coala-bears
 * [new branch]      Makman2/crosstest -> fork/Makman2/crosstest
 * [new branch]      Makman2/docproto -> fork/Makman2/docproto
 * [new branch]      Makman2/postcss -> fork/Makman2/postcss
 * [new branch]      Makman2/testing-crosstest -> fork/Makman2/testing-crosstest
 * [new branch]      Makman2/tmp -> fork/Makman2/tmp
 * [new branch]      MarkdownBear_linelength -> fork/MarkdownBear_linelength
 * [new branch]      abhsag/linebreak -> fork/abhsag/linebreak
 * [new branch]      fixannot   -> fork/fixannot
 * [new branch]      hypothesist/wip -> fork/hypothesist/wip
 * [new branch]      markdown_fix -> fork/markdown_fix
 * [new branch]      markdown_remark-validate-links -> fork/markdown_remark-validate-links
 * [new branch]      master     -> fork/master
 * [new branch]      red/extend-upload-tool -> fork/red/extend-upload-tool
 * [new branch]      release/0.1 -> fork/release/0.1
 * [new branch]      release/0.2 -> fork/release/0.2
 * [new branch]      release/0.7 -> fork/release/0.7
 * [new branch]      release/0.8 -> fork/release/0.8
 * [new branch]      release/0.9 -> fork/release/0.9
 * [new branch]      sanketdg/docextration/capitalizebear -> fork/sanketdg/docextration/capitalizebear
 * [new branch]      sanketdg/docformatbear -> fork/sanketdg/docformatbear
 * [new branch]      sils/bfx   -> fork/sils/bfx
 * [new branch]      sils/infer -> fork/sils/infer
 * [new branch]      sils/lc    -> fork/sils/lc
 * [new branch]      sils/linters -> fork/sils/linters
 * [new branch]      sils/pmd   -> fork/sils/pmd
 * [new branch]      sils/quotes -> fork/sils/quotes
 * [new branch]      sils/sec   -> fork/sils/sec
 * [new branch]      sils/tailor -> fork/sils/tailor
 * [new branch]      sils/tailorbackport -> fork/sils/tailorbackport
 * [new branch]      sils/upgcoala -> fork/sils/upgcoala
 * [new branch]      sils/yapf-old -> fork/sils/yapf-old
 * [new branch]      underyx/go-caching -> fork/underyx/go-caching
 * [new branch]      underyx/req-version-specs -> fork/underyx/req-version-specs
 * [new branch]      xml_style  -> fork/xml_style
+ args=
+ '[' only == default ']'
+ '[' only == no ']'
+ '[' only == only ']'
+ args=' --ff-only'
+ export BRANCH=__rultor
+ BRANCH=__rultor
++ git show-branch __rultor
++ wc -l
+ '[' 0 -gt 0 ']'
+ git checkout -B __rultor fork/markdown_fix
Switched to a new branch '__rultor'
Branch __rultor set up to track remote branch markdown_fix from fork.
+ git checkout -B master origin/master
Switched to and reset branch 'master'
Branch master set up to track remote branch master from origin.
+ '[' false == true ']'
+ '[' false == true ']'
+ git merge --ff-only __rultor
fatal: Not possible to fast-forward, aborting.
'cid' file is absent, container wasn't started correctly

fneu · 2017-01-11T21:43:34Z

@namanyadav12 please rebase on lastest master, thanks :)

jayvdb · 2017-01-12T06:39:45Z

package.json

@@ -16,7 +16,7 @@
    "jshint": "~2",
    "postcss-cli": "~2",
    "remark-cli": "~2",
-    "remark-lint": ">=5.1.0",
+    "remark-lint": "~5.1.0",


Is this change related?
Is the problem that 5.4.0 (the latest) was being installed, and that version is broken??
If yes ... that needs to be clearly stated in the commit message.
If these tests work with 5.4.0, then changing this file should be a separate PR, as it is not related.

(Note that due to caching, it isnt obvious which versions are installed in the logs, unless the build is without the cache)

jayvdb · 2017-01-12T06:40:16Z

unack 2e2ce17

jayvdb

I do not see any information on the issue, or PR, which suggests that this PR can fix the bug.
Adding tests obviously can not fix a bug.
And there is no analysis of the versions of remark-lint which might explain why altering the package.json will fix the bug (it might, but I cant see any analysis).

namanyadav12 · 2017-01-12T07:15:00Z

@jayvdb the commit message is already modified. I changed it earlier when sils asked me to.
The title of the pr is however the same. I will change that also.

namanyadav12 · 2017-01-12T07:28:15Z

Also changed Closes to Related to

jayvdb · 2017-01-12T07:42:38Z

I think you have two spaces after "Related to ", and you still include the change to "package.json".
(git checkout HEAD~1 package.json to remove that, then commit and push)

jayvdb · 2017-01-13T10:54:01Z

ack 99ca12e

jayvdb · 2017-01-13T10:55:37Z

https://circleci.com/gh/coala/coala-bears/4882 has passed on CircleCI, but Github is still waiting for it to finish :/

I'm going to restart it

jayvdb · 2017-01-13T11:16:46Z

needs rebase

A better test for MarkdownBear to check the exact message of the result for a maximum line length error. Related to coala#1235

aptrishu · 2017-01-13T16:48:16Z

ack 6663f7b

aptrishu · 2017-01-13T16:51:53Z

@rultor merge

rultor · 2017-01-13T16:57:49Z

@rultor merge

@aptrishu OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2017-01-13T16:59:16Z

@rultor merge

@aptrishu Done! FYI, the full log is here (took me 1min)

gitmate-bot added process/pending review size/S review carefully! labels Jan 10, 2017

namanyadav12 mentioned this pull request Jan 10, 2017

MarkdownBear doesn't work anymore #1235

Open

namanyadav12 force-pushed the markdown_fix branch from 4b24fc5 to c44bfb2 Compare January 10, 2017 05:07

sils reviewed Jan 10, 2017

View reviewed changes

coala-bot added process/wip and removed process/pending review labels Jan 10, 2017

namanyadav12 force-pushed the markdown_fix branch from c44bfb2 to 7abd34b Compare January 10, 2017 15:05

gitmate-bot added process/pending review and removed process/wip labels Jan 10, 2017

namanyadav12 force-pushed the markdown_fix branch from 7abd34b to f1a0a25 Compare January 10, 2017 15:08

namanyadav12 force-pushed the markdown_fix branch from f1a0a25 to 2e2ce17 Compare January 12, 2017 03:40

jayvdb reviewed Jan 12, 2017

View reviewed changes

jayvdb requested changes Jan 12, 2017

View reviewed changes

namanyadav12 changed the title ~~MarkdownBear: Fix MarkdownBear~~ MarkdownBear: Add test to check message for error Jan 12, 2017

namanyadav12 force-pushed the markdown_fix branch from 2e2ce17 to c639702 Compare January 12, 2017 07:21

jayvdb added process/wip and removed process/pending review labels Jan 12, 2017

namanyadav12 force-pushed the markdown_fix branch from c639702 to 99ca12e Compare January 12, 2017 07:55

gitmate-bot added process/pending review and removed process/wip labels Jan 12, 2017

jayvdb approved these changes Jan 13, 2017

View reviewed changes

MarkdownBear: Add test to check message for error

6663f7b

A better test for MarkdownBear to check the exact message of the result for a maximum line length error. Related to coala#1235

namanyadav12 force-pushed the markdown_fix branch from 99ca12e to 6663f7b Compare January 13, 2017 13:56

rultor merged commit 6663f7b into coala:master Jan 13, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MarkdownBear: Add test to check message for error #1280

MarkdownBear: Add test to check message for error #1280

namanyadav12 commented Jan 10, 2017 •

edited

Loading

gitmate-bot commented Jan 10, 2017

sils Jan 10, 2017

namanyadav12 Jan 10, 2017

sils commented Jan 10, 2017

sils commented Jan 10, 2017

gitmate-bot commented Jan 10, 2017

fneu commented Jan 11, 2017

fneu commented Jan 11, 2017

rultor commented Jan 11, 2017

rultor commented Jan 11, 2017

fneu commented Jan 11, 2017

jayvdb Jan 12, 2017

jayvdb commented Jan 12, 2017

jayvdb left a comment

namanyadav12 commented Jan 12, 2017 •

edited

Loading

namanyadav12 commented Jan 12, 2017

jayvdb commented Jan 12, 2017

jayvdb commented Jan 13, 2017

jayvdb commented Jan 13, 2017

jayvdb commented Jan 13, 2017

aptrishu commented Jan 13, 2017

aptrishu commented Jan 13, 2017

rultor commented Jan 13, 2017

rultor commented Jan 13, 2017

MarkdownBear: Add test to check message for error #1280

MarkdownBear: Add test to check message for error #1280

Conversation

namanyadav12 commented Jan 10, 2017 • edited Loading

gitmate-bot commented Jan 10, 2017

sils Jan 10, 2017

Choose a reason for hiding this comment

namanyadav12 Jan 10, 2017

Choose a reason for hiding this comment

sils commented Jan 10, 2017

sils commented Jan 10, 2017

gitmate-bot commented Jan 10, 2017

fneu commented Jan 11, 2017

fneu commented Jan 11, 2017

rultor commented Jan 11, 2017

rultor commented Jan 11, 2017

fneu commented Jan 11, 2017

jayvdb Jan 12, 2017

Choose a reason for hiding this comment

jayvdb commented Jan 12, 2017

jayvdb left a comment

Choose a reason for hiding this comment

namanyadav12 commented Jan 12, 2017 • edited Loading

namanyadav12 commented Jan 12, 2017

jayvdb commented Jan 12, 2017

jayvdb commented Jan 13, 2017

jayvdb commented Jan 13, 2017

jayvdb commented Jan 13, 2017

aptrishu commented Jan 13, 2017

aptrishu commented Jan 13, 2017

rultor commented Jan 13, 2017

rultor commented Jan 13, 2017

namanyadav12 commented Jan 10, 2017 •

edited

Loading

namanyadav12 commented Jan 12, 2017 •

edited

Loading