Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release coala 0.10 image #125

Closed
underyx opened this issue Feb 27, 2017 · 20 comments
Closed

Release coala 0.10 image #125

underyx opened this issue Feb 27, 2017 · 20 comments

Comments

@underyx
Copy link
Member

underyx commented Feb 27, 2017

It's been three weeks since the coala release 👯

@chauffer tried bumping the version but MarkdownBear seemed to have some issues (which aren't happening with 0.9), it was trying to remove all content from markdown files. If I recall correct that happens when the wrong remark (remark instead of remark-cli) is installed. Can we investigate that?

@underyx
Copy link
Member Author

underyx commented Feb 27, 2017

This could be related, too coala/coala-bears#1444

What do you think @jayvdb?

@underyx
Copy link
Member Author

underyx commented Feb 27, 2017

cc @sils as well

@fneu
Copy link
Contributor

fneu commented Mar 7, 2017

@jayvdb is there anything stopping this? Otherwise I'd try to make a release later today

@sils
Copy link
Member

sils commented Mar 7, 2017

@fneu ☝️ March 7, 2017 9:09 AM

@jayvdb
Copy link
Member

jayvdb commented Mar 7, 2017

The outstanding problem is 0.10 has checkstyle problems, with fixes merged but not yet released.
One possible solution is #50 , which ensures the images has it so no extra fetch is needed/cant break.

@fneu
Copy link
Contributor

fneu commented Mar 7, 2017

so adding the checkstyle.jar to /usr/local/share/coala-bears/CheckstyleBear/ would be enough for now to release 0.10?

@jayvdb is that and the release branch something you could take care of?

@jayvdb
Copy link
Member

jayvdb commented Mar 7, 2017

Yup, correct.

Not easy for me to do atm. On tablet only trying to fix laptop atm.
After that, if someone can push a branch 'release/0.10', it will voodoo be 0.10 because of #123 .

@fneu
Copy link
Contributor

fneu commented Mar 7, 2017

@jayvdb like this? #131

@underyx
Copy link
Member Author

underyx commented Mar 8, 2017

The problem I mentioned in the description is not fixed in the 0.10 image. MarkdownBear is still just deleting everything.

@fneu
Copy link
Contributor

fneu commented Mar 8, 2017

@underyx that sounds horrifying indeed. While there is a 0.10 docker tag atm, latest still points at 0.9 for now.

The thing is, inside the dockerfile we call npm install using the package.json provided by coala which includes remark-cli as well as remark-lint. These seem to get installed as to the output here.

Unfortunately I cannot run the images atm because of memory limitations on my only device, I need to repartition something to give myself some more freedom but I cannot do that until the weekend.

@jayvdb can you investigate?

@fneu
Copy link
Contributor

fneu commented Mar 8, 2017

seems to be a coala/MarkdownBear related issue independent of docker

@underyx
Copy link
Member Author

underyx commented Mar 14, 2017

From coala-bears 0.10.1 changelog:

Remark dependency has been pinned back to ~5.4 because version 6 changes
current behavior and breaks tests

From inside the coala/base:0.10 image:

bash-4.4# remark --version
remark: 6.2.0, remark-cli: 2.1.0

So, I'm pretty sure as noted on gitter it's still just a question of uploading the image with the correct coala-bears version. Could someone do that?

@underyx
Copy link
Member Author

underyx commented Mar 14, 2017

(@jayvdb seems like the obvious user to tag here)

@jayvdb
Copy link
Member

jayvdb commented Mar 14, 2017

@underyx , the problem with MarkdownBear has been occurring since December. See coala/coala-bears#1235

That commit message was a bit confusing, unless you look at the diff.
remark-lint is now 7, so it needed to be pinned to 6.
remark-cli is now 3, so it needed to be pinned to 2.

latest was still pointing at 0.9 ; I've now updated it to point to 0.10, and started builds for 0.9 and 0.10 and latest

@jayvdb
Copy link
Member

jayvdb commented Apr 20, 2017

This is blocked by coala/coala-bears#1625

@jayvdb
Copy link
Member

jayvdb commented Apr 20, 2017

And there could also be a problem with cabal , for which there isnt an easy backport as coala-bears.cabal was created after the 0.10 release.

@jayvdb
Copy link
Member

jayvdb commented Apr 20, 2017

Problems all fixed.

Green build using this docker master with the bears branch release/0.10 : https://travis-ci.org/jayvdb/docker-coala-base/builds/224080527

So, I've fast forward merged master into the branch release/0.10, and then will trigger a docker build.

The 0.10 image will already be smaller than prior images, but we can also revert #134 on the 0.10 release branch, as that is only needed for 0.11 bears. Started that now: #163

@jayvdb
Copy link
Member

jayvdb commented Apr 21, 2017

Any objections to moving 'latest' to '0.10'?

@jayvdb
Copy link
Member

jayvdb commented Apr 28, 2017

I have updated 'latest' to 0.10, and it is building now. 1 hr until build completion to raise an objection.

@jayvdb
Copy link
Member

jayvdb commented Apr 28, 2017

latest is now 0.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants