Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HSCParticle object to be compatible with MiniAOD #46840

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

enibigir
Copy link
Contributor

@enibigir enibigir commented Dec 2, 2024

PR description:

This PR added new objects for the HSCP collection in MiniAOD

PR validation:

The following tests have been performed successfully:

  • scram b runtests use-ibeos
  • runTheMatrix.py -l limited -i all --ibeos
  • scram build code-checks
  • scram build code-format

@cmsbuild cmsbuild added this to the CMSSW_15_0_X milestone Dec 2, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

This PR contains too many commits (1159 >= 240) and will not be processed.
Please ensure you have selected the correct target branch and consider squashing unnecessary commits.
The processing of this PR will resume once the commit count drops below the limit.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46840/42863

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024

A new Pull Request was created by @enibigir for master.

It involves the following packages:

  • AnalysisDataFormats/SUSYBSMObjects (analysis)

@cmsbuild, @tvami can you please review it and eventually sign? Thanks.
@missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Dec 3, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abafd9/43227/summary.html
COMMIT: 4779f7c
CMSSW: CMSSW_15_0_X_2024-12-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46840/43227/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3484682
  • DQMHistoTests: Total failures: 480
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3484182
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 1 / 44 workflows

@tvami
Copy link
Contributor

tvami commented Dec 3, 2024

@cmsbuild , please test workflow 11684.0

  • I think this actually uses the object

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024

-1

Failed Tests: RelVals
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abafd9/43229/summary.html
COMMIT: 4779f7c
CMSSW: CMSSW_15_0_X_2024-12-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46840/43229/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 11684.0

@tvami
Copy link
Contributor

tvami commented Dec 3, 2024

Undefined workflows: 11684.0

Hmm ok then this was removed in the meantime...

@tvami
Copy link
Contributor

tvami commented Dec 3, 2024

+analysis

  • tests looks good, PR extends the HSCP object

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@tvami
Copy link
Contributor

tvami commented Dec 3, 2024

@enibigir can you rename the PR to "Update HSCParticle object to be compatible with MiniAOD", or something similar? In the end you dont actually add a new object type here, just update/extend it.

@enibigir enibigir changed the title HSCP new object type Update HSCParticle object to be compatible with MiniAOD Dec 3, 2024
@mandrenguyen
Copy link
Contributor

+1

@mandrenguyen
Copy link
Contributor

ignore tests-rejected with ib-failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants