-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HSCParticle object to be compatible with MiniAOD #46840
Conversation
This PR contains too many commits (1159 >= 240) and will not be processed. |
ebba602
to
f1b11eb
Compare
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46840/42863 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46840/42884 |
A new Pull Request was created by @enibigir for master. It involves the following packages:
@cmsbuild, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
@cmsbuild , please test workflow 11684.0
|
-1 Failed Tests: RelVals RelValsValueError: Undefined workflows: 11684.0 |
Hmm ok then this was removed in the meantime... |
+analysis
|
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
@enibigir can you rename the PR to "Update HSCParticle object to be compatible with MiniAOD", or something similar? In the end you dont actually add a new object type here, just update/extend it. |
+1 |
ignore tests-rejected with ib-failure |
PR description:
This PR added new objects for the HSCP collection in MiniAOD
PR validation:
The following tests have been performed successfully: