Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Run4 for Phase2 PU inputs #46841

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Use Run4 for Phase2 PU inputs #46841

merged 1 commit into from
Dec 2, 2024

Conversation

AdrianoDee
Copy link
Contributor

PR description:

Trivial fix for the PU input to be used in Phase2 wfs. Spotted by @Parsifal-2045 (thanks!) in #46839.

PR validation:

None

@AdrianoDee
Copy link
Contributor Author

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46841/42859

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

+1

Size: This PR adds an extra 60KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7175e2/43186/summary.html
COMMIT: af83a93
CMSSW: CMSSW_15_0_X_2024-12-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46841/43186/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7175e2/43186/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7175e2/43186/git-merge-result

Comparison Summary

Summary:

@Moanwar
Copy link
Contributor

Moanwar commented Dec 2, 2024

+Upgrade

@AdrianoDee
Copy link
Contributor Author

test parameters:

  • relval_opt = -w upgrade
  • relval = 29807

@AdrianoDee
Copy link
Contributor Author

please test

@AdrianoDee
Copy link
Contributor Author

+pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7175e2/43192/summary.html
COMMIT: af83a93
CMSSW: CMSSW_15_0_X_2024-12-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46841/43192/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7175e2/43192/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7175e2/43192/git-merge-result

Comparison Summary

Summary:

  • You potentially added 18 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 3732 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3589421
  • DQMHistoTests: Total failures: 43907
  • DQMHistoTests: Total nulls: 74
  • DQMHistoTests: Total successes: 3545420
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 206 log files, 176 edm output root files, 47 DQM output files
  • TriggerResults: found differences in 1 / 45 workflows

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c9ac3b7 into cms-sw:master Dec 2, 2024
12 checks passed
@AdrianoDee AdrianoDee deleted the patch-16 branch December 3, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants