Add time to HGCAL CaloParticles

[AuroraPerego]

PR description:

Following the MtdTruthAccumulator.cc logic, the SimVertex time has also been added to the HGCAL CaloParticles.
This is needed because the information coming from the SimVertexCollection of the CaloParticles from pileup is lost if not saved in the CaloTruthAccumulator.cc.
The name of the method used to assign the time has been changed to the more appropriate setSimTime.
The correction of the time for oot pileup has been removed since the SimVertex time takes that already into account.

PR validation:

Tested on wfs 29888.203 (classical mixing) and 29888.99 (premix) enabling the CaloParticles from pileup (they are disabled by default).
Example to test it:

test parameters:
    - workflow_opts= -w upgrade
    - workflow = 29888.99,29888.203

FYI @waredjeb @felicepantaleo @rovere

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46678/42605

[cmsbuild]

A new Pull Request was created by @AuroraPerego for master.

It involves the following packages:

• RecoHGCal/TICL (reconstruction, upgrade)
• SimDataFormats/CaloAnalysis (simulation)
• SimGeneral/CaloAnalysis (simulation)
• SimGeneral/MixingModule (simulation)

@Moanwar, @civanch, @cmsbuild, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@ReyerBand, @apsallid, @bsunanda, @fabiocos, @felicepantaleo, @forthommel, @hatakeyamak, @lecriste, @makortel, @martinamalberti, @missirol, @mmusich, @rovere, @sameasy, @slomeo, @sobhatta, @thomreis, @wang0jin, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[fwyzard]

allow @AuroraPerego test rights

[Moanwar]

Hi, just a small comment—I don't see the usage of bunchSpacing. Maybe I'm missing something? Thanks

[AuroraPerego]

Yes sorry, it was a leftover from previous changes. I've removed it.

[jfernan2]

Is this 1e9 a conversion to ns? If so, perhaps set it as a constant?

[AuroraPerego]

It's from seconds to ns, I've changed it to use the constant s from CLHEP.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46678/42615

[cmsbuild]

Pull request #46678 was updated. @Moanwar, @civanch, @cmsbuild, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @srimanob, @subirsarkar can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46678/42616

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X.

[Moanwar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1

[mmusich]

just for the record, it looks like this PR makes the phase2 HLT timing test crash e.g. log:

----- Begin Fatal Exception 03-Dec-2024 09:28:34 CET-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Calling InputSource::readFile_
   [1] Calling RootInputFileSequence::initTheFile()
   Additional Info:
      [a] Input file file:/data/user/cmsbuild//store/relval/CMSSW_14_1_0_pre6/RelValTTbar_14TeV/GEN-SIM-DIGI-RAW/PU_141X_mcRun4_realistic_v1_STD_2026D110_PU-v3/2810000/07aa8d40-9725-47e8-b476-2dd518958f17.root could not be opened.
      [b] Fatal Root Error: @SUB=TStreamerInfo::BuildCheck

   The StreamerInfo for version 4 of class CaloParticle read from the file ///data/user/cmsbuild//store/relval/CMSSW_14_1_0_pre6/RelValTTbar_14TeV/GEN-SIM-DIGI-RAW/PU_141X_mcRun4_realistic_v1_STD_2026D110_PU-v3/2810000/07aa8d40-9725-47e8-b476-2dd518958f17.root
   has a different checksum than the previously loaded StreamerInfo.
   Reading objects of type CaloParticle from the file ///data/user/cmsbuild//store/relval/CMSSW_14_1_0_pre6/RelValTTbar_14TeV/GEN-SIM-DIGI-RAW/PU_141X_mcRun4_realistic_v1_STD_2026D110_PU-v3/2810000/07aa8d40-9725-47e8-b476-2dd518958f17.root 
   (and potentially other files) might not work correctly.
   Most likely the version number of the class was not properly
   updated [See ClassDef(CaloParticle,4)].

----- End Fatal Exception -------------------------------------------------

@AuroraPerego @felicepantaleo

[rovere]

This PR changes the class layout of both CaloParticle and MTDCaloParticle w/o increasing the class version in the proper xml file.
Aren't we catching this kind of compilation warnings?

[AuroraPerego]

Aren't we catching this kind of compilation warnings?

Apparently, we are not now (scram b gives no warnings/errors). I ran scram b updateclassversion and it did not fail, while edmCheckClassVersion generated the new checksum correctly.
I'll test the phase2 HLT timing test with the new checksum, but there is probably an issue with scram not catching it (?).
Maybe @smuzaffar has more insights into this.

[mmusich]

I'll test the phase2 HLT timing test with the new checksum, but there is probably an issue with scram not catching it (?).

I tested it fixes the phase2 HLT timing and opened #46851

[smuzaffar]

@AuroraPerego thanks for pinging me. buildrules are searching for FWCore/Utilities/scripts/edmCheckClassVersion and if not found then it just skip the class version checks. As #45423 moved this file under FWCore/Reflection/scripts/edmCheckClassVersion that is why edm class checks were not run. I will update the build rules to

[smuzaffar]

cms-sw/cmsdist#9543 should properly catch mismatching class versions