Make ROOT 6.32 as default for 15.0.X #9541

smuzaffar · 2024-11-28T08:46:41Z

Root 6.32 validation looks good cms-sw/cmssw#45556

smuzaffar · 2024-11-28T08:46:54Z

test parameters:

full_cmssw = true

cmsbuild · 2024-11-28T08:47:01Z

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_15_0_X/master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

smuzaffar · 2024-11-28T08:47:01Z

please test

cmsbuild · 2024-11-28T08:47:02Z

cms-bot internal usage

cmsbuild · 2024-11-28T14:21:55Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-451bf6/43129/summary.html
COMMIT: 99850ea
CMSSW: CMSSW_15_0_X_2024-11-27-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9541/43129/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-451bf6/43129/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-451bf6/43129/git-merge-result

Unit Tests

I found 3 errors in the following unit tests:

---> test TestFWCoreModulesEmptySourceFromEventIDs had ERRORS
---> test TestFWCoreReflectionClassVersionUpdate had ERRORS
---> test TestIOPoolInputNoParentDictionary had ERRORS

Comparison Summary

Summary:

You potentially removed 167 lines from the logs
Reco comparison results: 1226 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3484682
DQMHistoTests: Total failures: 8256
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3476406
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 202 log files, 172 edm output root files, 46 DQM output files
TriggerResults: found differences in 1 / 44 workflows

smuzaffar · 2024-11-28T15:04:34Z

+externals

unit tests failure are know:

TestFWCoreModulesEmptySourceFromEventIDs: know issue with this unit tests (see Fix EmptySourceFromEventIDs test configuration cmssw#46825 )
TestFWCoreReflectionClassVersionUpdate : Always fails for PR tests when root version is updated
TestIOPoolInputNoParentDictionary: Always fails for PR tests when root version is updated

cmsbuild · 2024-11-28T15:04:55Z

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_15_0_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

smuzaffar · 2024-12-02T16:41:58Z

please test

lets refresh PR tests

cmsbuild · 2024-12-02T20:54:19Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-451bf6/43194/summary.html
COMMIT: 99850ea
CMSSW: CMSSW_15_0_X_2024-12-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9541/43194/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-451bf6/43194/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-451bf6/43194/git-merge-result

Unit Tests

I found 2 errors in the following unit tests:

---> test TestFWCoreReflectionClassVersionUpdate had ERRORS
---> test TestIOPoolInputNoParentDictionary had ERRORS

Comparison Summary

Summary:

You potentially removed 151 lines from the logs
Reco comparison results: 1228 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3484682
DQMHistoTests: Total failures: 8248
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3476414
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 202 log files, 172 edm output root files, 46 DQM output files
TriggerResults: found differences in 1 / 44 workflows

cmsbuild · 2024-12-16T06:09:55Z

Pull request #9541 was updated.

smuzaffar · 2024-12-16T06:10:39Z

please test

smuzaffar · 2024-12-16T09:54:44Z

+externals

as 15.0.0.pre1 has been built, so merging root 6.32 in to 15.0.X default IBs

cmsbuild · 2024-12-16T09:55:02Z

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_15_0_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2024-12-16T10:39:05Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-451bf6/43459/summary.html
COMMIT: 2cb622a
CMSSW: CMSSW_15_0_X_2024-12-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9541/43459/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 4 errors in the following unit tests:

---> test TestFWCoreReflectionClassVersionUpdate had ERRORS
---> test TestIOPoolInputNoParentDictionary had ERRORS
---> test TestDQMOfflineConfigurationGotAll had ERRORS
and more ...

Comparison Summary

Summary:

You potentially removed 147 lines from the logs
Reco comparison results: 1657 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3510017
DQMHistoTests: Total failures: 9140
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3500857
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 202 log files, 172 edm output root files, 46 DQM output files
TriggerResults: found differences in 2 / 44 workflows

cmsbuild added tests-pending externals-pending pending-signatures orp-pending labels Nov 28, 2024

cmsbuild added tests-started and removed tests-pending labels Nov 28, 2024

cmsbuild added tests-rejected and removed tests-started labels Nov 28, 2024

cmsbuild added externals-approved fully-signed and removed externals-pending pending-signatures labels Nov 28, 2024

makortel mentioned this pull request Dec 2, 2024

ROOT 6.32 validation cms-sw/cmssw#45556

Closed

cmsbuild added tests-started and removed tests-rejected labels Dec 2, 2024

cmsbuild added tests-rejected and removed tests-started labels Dec 2, 2024

Make ROOT 6.32 as default for 15.0.X

2cb622a

smuzaffar force-pushed the 150x-root632 branch from 99850ea to 2cb622a Compare December 16, 2024 06:09

cmsbuild removed tests-rejected externals-approved labels Dec 16, 2024

cmsbuild added tests-pending externals-pending pending-signatures and removed fully-signed labels Dec 16, 2024

smuzaffar changed the title ~~[15.0.X]Move to ROOT 6.32~~ Make ROOT 6.32 as default for 15.0.X Dec 16, 2024

cmsbuild added tests-started and removed tests-pending labels Dec 16, 2024

smuzaffar merged commit cea3760 into IB/CMSSW_15_0_X/master Dec 16, 2024
8 of 10 checks passed

cmsbuild added externals-approved fully-signed and removed externals-pending pending-signatures labels Dec 16, 2024

cmsbuild added tests-rejected and removed tests-started labels Dec 16, 2024

cmsbuild mentioned this pull request Dec 16, 2024

testing code rules cms-sw/cmssw-config#112

Closed

smuzaffar deleted the 150x-root632 branch December 18, 2024 14:34

cmsbuild mentioned this pull request Jan 8, 2025

[ROOT634]Updated root to tip of branch v6-34-00-patches #9598

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make ROOT 6.32 as default for 15.0.X #9541

Make ROOT 6.32 as default for 15.0.X #9541

smuzaffar commented Nov 28, 2024 •

edited

Loading

smuzaffar commented Nov 28, 2024

cmsbuild commented Nov 28, 2024

smuzaffar commented Nov 28, 2024

cmsbuild commented Nov 28, 2024 •

edited

Loading

cmsbuild commented Nov 28, 2024

smuzaffar commented Nov 28, 2024

cmsbuild commented Nov 28, 2024

smuzaffar commented Dec 2, 2024

cmsbuild commented Dec 2, 2024

cmsbuild commented Dec 16, 2024

smuzaffar commented Dec 16, 2024

smuzaffar commented Dec 16, 2024

cmsbuild commented Dec 16, 2024

cmsbuild commented Dec 16, 2024

Make ROOT 6.32 as default for 15.0.X #9541

Make ROOT 6.32 as default for 15.0.X #9541

Conversation

smuzaffar commented Nov 28, 2024 • edited Loading

smuzaffar commented Nov 28, 2024

cmsbuild commented Nov 28, 2024

smuzaffar commented Nov 28, 2024

cmsbuild commented Nov 28, 2024 • edited Loading

cmsbuild commented Nov 28, 2024

Unit Tests

Comparison Summary

smuzaffar commented Nov 28, 2024

cmsbuild commented Nov 28, 2024

smuzaffar commented Dec 2, 2024

cmsbuild commented Dec 2, 2024

Unit Tests

Comparison Summary

cmsbuild commented Dec 16, 2024

smuzaffar commented Dec 16, 2024

smuzaffar commented Dec 16, 2024

cmsbuild commented Dec 16, 2024

cmsbuild commented Dec 16, 2024

Unit Tests

Comparison Summary

smuzaffar commented Nov 28, 2024 •

edited

Loading

cmsbuild commented Nov 28, 2024 •

edited

Loading