TriggerResultsFilterFromDB: accept all triggers paths in presence of an empty list of expressions

[mmusich]

PR description:

In PR #42965 (and similarly more recently in #46742) few AlCaReco producers were changed such that TriggerResultsFilterFromDB is employed instead of HLTHighLevel to select events.
The two behave differently in presence of an empty logic expression: HLTHighLevel selects all events (filter effectively is ignored), while TriggerResultsFilterFromDB accepts none.
The goal of this PR is to make the behaviour uniform among the two. This is particularly convenient because the empty expression list is very common in many eventSetupPath keys across different Global Tags and it would avoid to make massive clean-up campaign.
While this PR changes the behaviour of the module I couldn't find any other consumers of it other than named AlCaReco producers, so it should be safe to do.

PR validation:

Used the configuration file obtained from the following cmsDriver command (borrowed from this JIRA ticket and the stats2 link therein) that used to produce an empty dataset:

#!/bin/bash -ex                                                                                                                                                                                            

cmsDriver.py step3 \
             --conditions 141X_mcRun3_2024_realistic_HI_Candidate_2024_11_19_14_38_08 \
             --datatier ALCARECO \
             --era Run3_pp_on_PbPb_2023 \
             --eventcontent ALCARECO \
             --filein /store/relval/CMSSW_14_1_6/RelValHydjetQ_B12_5362GeV_2024/GEN-SIM-RECO/141X_mcRun3_2024_realistic_HI_Candidate_2024_11_19_14_38_08_MinBias_2024HIN_noPU_RV257-v2/2590000/0052ce44-83\
da-4782-b2f7-3e16e58e42be.root \
             --fileout file:step3.root \
             --nStreams 1 \
             --nThreads 8 \
             --no_exec \
             --number 100 \
             --python_filename step_3_cfg.py \
             --step ALCA:TkAlMinBias+SiStripCalMinBias

and verified that there are events in output, where the same command without this PR produces a file without any events in it.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, might be backported.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46833/42853

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• HLTrigger/HLTfilters (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df9fac/43171/summary.html
COMMIT: 958ec12
CMSSW: CMSSW_15_0_X_2024-11-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46833/43171/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3484682
• DQMHistoTests: Total failures: 440
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3484222
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[mmusich]

+hlt

• changes worked fine in PR Use TriggerResultsFilterFromDB instead of HLTHighLevel, in order to allow prescaled HLT paths in EcalESAlign and HcalCalIterativePhiSym  #46742

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1