Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TriggerResultsFilterFromDB-based selection for Heavy AlCaRecos in pp_on_AA #42965

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 7, 2023

PR description:

In this cmsTalk post it was proposed to cut down the number of PDs in which the TkAlMinBias and SiStripCalMinBias producers are run to avoid producing too large datasets during the 2023 HIon run.
An alternative (or complementary) approach consists in prescaling the number of events accepted for each of the trigger paths firing (and accepted by the AlCaReco).
This can be done using the TriggerResultsFilterFromDB module and appropriate usage of the eventSetupPathsKey-associated HLT patterns, e.g.:

  • HLT_HIPhysics_v*/10;HLT_HIPuAK4*/10;HLT_HICsAK4*/10;HLT_HIZeroBias_v*/10;HLT_HIMinimumBiasHF*/10

This is implemented in commit 70d8a19
The other commit of this PR (47bfc84) is purely technical an implements a leftover parameter in TriggerResultsFilterFromDB::fillDescriptions, necessary to be able to validate the configuration.

PR validation:

Run:

cmsDriver.py stepTest --conditions 132X_dataRun3_Prompt_v4 \
    --custom_conditions="AlCaRecoTriggerBits_testPrescales_HIMinBias_v0,AlCaRecoTriggerBitsRcd,frontier://FrontierPrep/CMS_CONDITIONS" \
    --data \
    --datatier ALCARECO \
    --era Run3 \
    --eventcontent ALCARECO \
    --filein /store/hidata/HIRun2023A/HIPhysicsRawPrime0/RAW/v1/000/374/646/00000/40fbbb7f-a214-40fe-a02b-04212c90e0d0.root \
    --fileout file:step2.root \
    --nStreams 4 \
    --nThreads 8 \
    --number 100 \
    --process reRECO \
    --repacked \
    --python_filename step_2_cfg.py \
    --scenario pp \
    --step RAW2DIGI,L1Reco,RECO,ALCA:SiStripCalMinBias+TkAlMinBias \
    --era Run3_pp_on_PbPb_approxSiStripClusters_2023 \
    --no_exec

and obtained the desired reduction in the event output.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but to be backported to CMSSW_13_2_X (eventually for 2023 HIon data-taking).

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42965/37132

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2023

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Alignment/CommonAlignmentProducer (alca)
  • Calibration/TkAlCaRecoProducers (alca)
  • HLTrigger/HLTfilters (hlt)

@saumyaphor4252, @Martin-Grunewald, @missirol, @perrotta, @consuegs, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@tocheng, @adewit, @threus, @tlampen, @Martin-Grunewald, @missirol, @pakhotin, @silviodonato, @mmusich this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@saumyaphor4252
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3b848/35090/summary.html
COMMIT: 70d8a19
CMSSW: CMSSW_13_3_X_2023-10-07-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42965/35090/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3356920
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3356895
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@saumyaphor4252
Copy link
Contributor

+alca

@mmusich
Copy link
Contributor Author

mmusich commented Oct 8, 2023

+hlt

  • change in HLT related package is trivial

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants