Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EmptySourceFromEventIDs test configuration #46825

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Nov 28, 2024

PR description:

Fix the EmptySourceFromEventIDs test configuration.

The EventIDChecker module requires that events be created and analysed in a specific order, which cannot be guaranteed in a multi-stream, multi-threaded configuration.

PR validation:

The TestFWCoreModulesEmptySourceFromEventIDs unit test should now pass.

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 28, 2024

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 28, 2024

type bugfix

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 28, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

  • FWCore/Modules (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c3b485/43136/summary.html
COMMIT: 11965fc
CMSSW: CMSSW_15_0_X_2024-11-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46825/43136/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3484682
  • DQMHistoTests: Total failures: 477
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3484185
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 1 / 44 workflows

@smuzaffar
Copy link
Contributor

+core

This PR only touches unit test TestFWCoreModulesEmptySourceFromEventIDs which should now work fine as events are processed in serial mode and should match the order defined in https://github.com/cms-sw/cmssw/blob/master/FWCore/Modules/test/testEmptySourceFromEventIDs_cfg.py#L5-L30

Comparison diff are related to #45505 and #46416

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit dbc4504 into cms-sw:master Nov 29, 2024
11 checks passed
@fwyzard fwyzard deleted the fix_EmptySourceFromEventIDs_test branch December 1, 2024 14:08
@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 10, 2024

type ngt

@cmsbuild cmsbuild added the ngt label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants