Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMSSW_14_1_X:Update HSCParticle object to be compatible with MiniAOD #46899

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

enibigir
Copy link
Contributor

@enibigir enibigir commented Dec 9, 2024

PR description:

This PR is a backport of #46840 already merged.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2024

A new Pull Request was created by @enibigir for CMSSW_14_1_X.

It involves the following packages:

  • AnalysisDataFormats/SUSYBSMObjects (analysis)

@cmsbuild, @tvami can you please review it and eventually sign? Thanks.
@missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2024

cms-bot internal usage

@tvami
Copy link
Contributor

tvami commented Dec 9, 2024

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a63f6a/43334/summary.html
COMMIT: ef5d22c
CMSSW: CMSSW_14_1_X_2024-12-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46899/43334/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 23 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3565709
  • DQMHistoTests: Total failures: 1619
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3564070
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 199 log files, 169 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Dec 10, 2024

+analysis

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cc2afa7 into cms-sw:CMSSW_14_1_X Dec 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants