Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_1_X] Update ecalMultiFitUncalibRecHit_cfi.py parameters for CC #46914

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

jking79
Copy link
Contributor

@jking79 jking79 commented Dec 11, 2024

BackPort of PR #46763

This PR does not affect the default reconstruction. The changes made by this PR are only activated by a special modifier. This PR is needed for a reprocessing discussed with PPD.

Changed ourOfTimeThresholdGain61pEB and ourOfTimeThresholdGain61mEB parameters for CC reconstruction from 3.0 to 12.0 on lines 15 and 16 of RecoLocalCalo/EcalRecProducers/python/ecalMultiFitUncalibRecHit_cfi.py

PR description:

This change address discrepancy seen in JERSF for TeV jets.

PR validation:

This PR makes an adjustment to config parameters and does not touch the code.

Details are documented in: SupplementalMaterialPR46763.pdf

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jking79 for CMSSW_14_1_X.

It involves the following packages:

  • RecoLocalCalo/EcalRecProducers (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@ReyerBand, @apsallid, @argiro, @denizsun, @missirol, @rchatter, @salimcerci, @thomreis, @wang0jin, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 11, 2024

cms-bot internal usage

@jking79 jking79 changed the title Update ecalMultiFitUncalibRecHit_cfi.py BackPort of PR 46763 Dec 11, 2024
@jfernan2
Copy link
Contributor

assign alca

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

New categories assigned: alca

@atpathak,@consuegs,@perrotta you have been requested to review this Pull request/Issue and eventually sign? Thanks

@jfernan2
Copy link
Contributor

type ecal

@cmsbuild cmsbuild added the ecal label Dec 11, 2024
@jfernan2
Copy link
Contributor

backport of #46763

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-456d28/43392/summary.html
COMMIT: e8a2794
CMSSW: CMSSW_14_1_X_2024-12-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46914/43392/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-456d28/43392/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-456d28/43392/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3565709
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3565686
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 199 log files, 169 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+alca

  • I would suggest either @jking79 or @cms-sw/orp-l2 to modify the title of the PR into something more easily understandable, for example "Update ecalMultiFitUncalibRecHit_cfi.py parameters for CC - CMSSW_14_1_X"

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela antoniovilela changed the title BackPort of PR 46763 [14_1_X] Update ecalMultiFitUncalibRecHit_cfi.py parameters for CC Dec 12, 2024
@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bdc4d08 into cms-sw:CMSSW_14_1_X Dec 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants