Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable 2022/2023 MC Tests #46843

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

AdrianoDee
Copy link
Contributor

PR description:

This PR proposes to disable test_MC_23_setup and test_MC_22_setup given the setup is now stable and well defined and also that we moved to 15_0_X. In principle this could be back ported to 14_2_X and 14_1_X given the final production is happening in 14_0_19 but, unless a problem arises (as it is with #41932), I'll just keep them.

Instead of completely removing them I prefer to comment the tests just to keep track of what was the final setup (without having to dig the git history).

FYI: @makortel

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

cms-bot internal usage

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46843/42860

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@AdrianoDee, @Moanwar, @DickyChant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10b2d0/43188/summary.html
COMMIT: 4e58c4f
CMSSW: CMSSW_15_0_X_2024-12-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46843/43188/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3484682
  • DQMHistoTests: Total failures: 483
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3484179
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 1 / 44 workflows

@AdrianoDee
Copy link
Contributor Author

+pdmv

@mmusich
Copy link
Contributor

mmusich commented Dec 6, 2024

@cms-sw/upgrade-l2 do you have any objection in merging this PR (it doesn't pertain to upgrade per se)?

@Moanwar
Copy link
Contributor

Moanwar commented Dec 6, 2024

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0ab151e into cms-sw:master Dec 6, 2024
11 checks passed
sihyunjeon pushed a commit to sihyunjeon/cmssw that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants