Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unbiased superclusters to miniAOD and EGM nano #46423

Merged
merged 10 commits into from
Oct 22, 2024

Conversation

SanghyunKo
Copy link
Contributor

@SanghyunKo SanghyunKo commented Oct 17, 2024

PR description:

This PR addresses two issues:

  1. Replace the ratio between corrected & uncorrected energy in Run 2 NanoAOD with the uncorrected energy itself (to avoid issues like Replace buggy UL2016 EGM energy correction files #46046 - if the correction is 0, we cannot recover the energy before applying the correction using the ratio). The NanoDQM plots are modified accordingly.

  2. Currently, EGM still relies on AOD to derive central reco SFs. This is because the supercluster (SC) collection stored in MiniAOD is highly biased since we only store the SC that already reconstructed electron & photon objects. This PR attempts to improve the situation by migrating from the legacy AOD-based workflow to the (EGM) nanoAOD-based workflow. A minimal change in miniAOD is required to remove the biases implied in the current miniAOD. Furthermore, the SC track isolation suggested in Adding in slimmed superclusters for EGM efficiency measurements to Mini #42007 is also incorporated into the EGM NanoAOD.

PR validation:

The expected increase in miniAOD file size is marginal - DY: 0.27%, TTto2L2Nu: 0.62%, TTto4Q: 1% (tested 1k events with SC pt > 5 GeV). The increase in EGM nanoAOD due to the new SC collection is approximately 2%. A quick validation on the new track isolation variable has been performed with the DY & TTto4Q samples:

DY
scTrkIso_DY

TTto4Q
scTrkIso_TTto4Q

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No backport is needed (this PR targets Nano v15).

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 17, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46423/42282

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46423/42283

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @SanghyunKo for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)
  • PhysicsTools/PatAlgos (xpog, reconstruction)
  • RecoEgamma/EgammaPhotonProducers (reconstruction)

@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@AlexDeMoor, @AnnikaStein, @Ming-Yan, @Prasant1993, @Sam-Harper, @Senphy, @a-kapoor, @afiqaize, @ahinzmann, @andrzejnovak, @azotz, @castaned, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jainshilpi, @jdamgov, @jdolen, @lgray, @mariadalfonso, @mbluj, @missirol, @mmarionncern, @nhanvtran, @ram1123, @rappoccio, @rovere, @sameasy, @schoef, @seemasharmafnal, @sobhatta, @valsdav, @varuns23 this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@hqucms
Copy link
Contributor

hqucms commented Oct 17, 2024

enable nano

@hqucms
Copy link
Contributor

hqucms commented Oct 17, 2024

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e79ae/42271/summary.html
COMMIT: d4762a9
CMSSW: CMSSW_14_2_X_2024-10-16-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46423/42271/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially added 70 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 116 differences found in the comparisons
  • DQMHistoTests: Total files compared: 21
  • DQMHistoTests: Total histograms compared: 55168
  • DQMHistoTests: Total failures: 24
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 55144
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 20 files compared)
  • Checked 102 log files, 58 edm output root files, 21 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001 3.000 2.997 0.003 ( +0.1% ) 2.93 2.91 +0.7% 6.163 6.085
2500.002 3.110 3.107 0.003 ( +0.1% ) 2.62 2.61 +0.4% 6.437 6.438
2500.003 3.054 3.051 0.002 ( +0.1% ) 2.74 2.75 -0.3% 6.414 6.415
2500.011 1.575 1.571 0.004 ( +0.3% ) 4.53 4.52 +0.2% 2.455 2.181
2500.012 2.093 2.088 0.006 ( +0.3% ) 2.75 2.77 -0.7% 2.641 2.224
2500.013 1.917 1.912 0.005 ( +0.3% ) 3.86 3.90 -0.9% 2.555 2.243
2500.021 0.022 0.022 0.000 ( +0.0% ) 0.88 0.87 +1.5% 2.416 2.386
2500.022 0.022 0.022 0.000 ( +0.0% ) 0.86 0.83 +3.1% 2.408 2.395
2500.023 0.022 0.022 0.000 ( +0.0% ) 0.84 0.81 +4.3% 2.278 2.263
2500.024 0.022 0.022 0.000 ( +0.0% ) 0.63 0.63 +0.8% 2.513 2.419
2500.031 0.035 0.035 0.000 ( +0.0% ) 0.78 0.76 +1.9% 2.485 2.448
2500.032 0.036 0.036 0.000 ( +0.0% ) 0.81 0.79 +2.5% 2.445 2.442
2500.033 0.037 0.037 0.000 ( +0.0% ) 0.73 0.71 +2.8% 2.523 2.465
2500.034 0.036 0.036 0.000 ( +0.1% ) 0.73 0.72 +2.5% 2.508 2.442
2500.101 2.753 2.753 0.000 ( +0.0% ) 7.27 7.28 -0.1% 7.040 6.431
2500.111 1.399 1.399 0.000 ( +0.0% ) 16.52 16.52 +0.0% 2.289 2.282
2500.112 1.818 1.818 0.000 ( +0.0% ) 13.51 13.40 +0.8% 2.375 2.366
2500.131 0.747 0.747 0.000 ( +0.0% ) 17.05 17.14 -0.5% 1.507 1.471
2500.201 2.582 2.582 0.000 ( +0.0% ) 6.20 6.19 +0.3% 6.315 5.700
2500.211 1.736 1.736 0.000 ( +0.0% ) 14.53 14.49 +0.3% 2.360 2.354
2500.212 2.131 2.131 0.000 ( +0.0% ) 11.97 11.76 +1.8% 2.437 2.434
2500.221 2.003 2.003 0.000 ( +0.0% ) 6.35 6.38 -0.4% 2.532 2.525
2500.222 3.372 3.309 0.063 ( +1.9% ) 6.13 6.11 +0.4% 2.619 2.603
2500.223 8.997 8.997 0.000 ( +0.0% ) 2.38 2.36 +0.7% 2.634 2.369
2500.224 6.026 6.026 0.000 ( +0.0% ) 0.57 0.58 -0.6% 2.674 2.205
2500.225 6.058 6.058 0.000 ( +0.0% ) 0.54 0.55 -0.9% 2.754 2.251
2500.226 3.072 3.072 0.000 ( +0.0% ) 6.13 6.06 +1.1% 2.608 2.195
2500.227 1.437 1.437 0.000 ( +0.0% ) 11.16 11.17 -0.1% 1.429 1.394
2500.231 1.408 1.408 0.000 ( +0.0% ) 11.87 11.76 +0.9% 2.255 2.232
2500.232 2.386 2.336 0.050 ( +2.1% ) 11.79 11.80 -0.1% 2.354 2.345
2500.233 4.783 4.783 0.000 ( +0.0% ) 3.93 3.92 +0.2% 2.374 2.371
2500.234 3.648 3.648 0.000 ( +0.0% ) 0.73 0.73 +0.4% 2.383 2.375
2500.235 3.667 3.667 0.000 ( +0.0% ) 0.71 0.71 -0.0% 2.446 2.442
2500.236 2.180 2.180 0.000 ( +0.0% ) 11.74 11.56 +1.5% 2.356 2.347
2500.237 1.016 1.016 0.000 ( +0.0% ) 16.31 16.48 -1.0% 1.464 1.462
2500.241 9.404 9.404 0.000 ( +0.0% ) 3.45 3.47 -0.4% 1.916 1.916
2500.242 10.331 10.331 0.000 ( +0.0% ) 0.84 0.83 +0.6% 1.708 1.706
2500.243 2.712 2.712 0.000 ( +0.0% ) 7.91 8.26 -4.3% 1.077 1.076
2500.244 485.976 485.976 0.000 ( +0.0% ) 0.53 0.53 -1.6% 1.673 1.688
2500.245 823.202 823.202 0.000 ( +0.0% ) 0.70 0.70 +0.0% 1.672 1.661
2500.901 1.777 1.777 0.000 ( +0.0% ) 19.91 20.14 -1.2% 1.846 1.845
2500.902 1.626 1.626 0.000 ( +0.0% ) 20.36 20.89 -2.5% 1.774 1.774
2500.911 13.995 13.995 0.000 ( +0.0% ) 2.79 3.20 -12.8% 1.097 1.096
2500.912 0.240 0.240 0.000 ( +0.0% ) 1.56 1.23 +27.6% 0.972 0.974
2500.913 0.110 0.110 0.000 ( +0.0% ) 1.05 1.04 +0.6% 0.975 0.980

@cmsbuild
Copy link
Contributor

Pull request #46423 was updated. @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e79ae/42326/summary.html
COMMIT: b2c2152
CMSSW: CMSSW_14_2_X_2024-10-21-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46423/42326/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially removed 549 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 116 differences found in the comparisons
  • DQMHistoTests: Total files compared: 21
  • DQMHistoTests: Total histograms compared: 55144
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 55144
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 7.593 KiB( 20 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 1.582 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.011,... ): 0.949 KiB Physics/NanoAODDQM
  • Checked 102 log files, 58 edm output root files, 21 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001 3.000 2.997 0.003 ( +0.1% ) 2.96 2.92 +1.6% 6.095 6.090
2500.002 3.110 3.107 0.003 ( +0.1% ) 2.66 2.60 +2.2% 6.436 6.440
2500.003 3.054 3.051 0.002 ( +0.1% ) 2.78 2.72 +2.3% 6.408 6.413
2500.011 1.575 1.571 0.004 ( +0.3% ) 4.67 4.56 +2.5% 2.182 2.174
2500.012 2.093 2.088 0.006 ( +0.3% ) 2.81 2.76 +2.0% 2.218 2.216
2500.013 1.917 1.912 0.005 ( +0.3% ) 3.99 3.90 +2.3% 2.243 2.238
2500.021 0.022 0.022 0.000 ( +0.0% ) 0.92 0.95 -3.3% 2.391 2.413
2500.022 0.022 0.022 0.000 ( +0.0% ) 0.88 0.89 -0.8% 2.370 2.402
2500.023 0.022 0.022 0.000 ( +0.2% ) 0.87 0.88 -1.3% 2.266 2.274
2500.024 0.022 0.022 0.000 ( +0.0% ) 0.66 0.68 -2.4% 2.310 2.436
2500.031 0.035 0.035 0.000 ( +0.0% ) 0.82 0.75 +8.3% 2.452 2.437
2500.032 0.036 0.036 0.000 ( +0.0% ) 0.83 0.79 +5.0% 2.444 2.439
2500.033 0.037 0.037 0.000 ( +0.0% ) 0.76 0.71 +5.8% 2.471 2.467
2500.034 0.036 0.036 0.000 ( +0.0% ) 0.76 0.73 +4.1% 2.446 2.444
2500.101 2.753 2.753 0.000 ( +0.0% ) 7.57 7.65 -1.1% 6.429 6.425
2500.111 1.399 1.399 0.000 ( +0.0% ) 17.02 17.28 -1.5% 2.294 2.287
2500.112 1.818 1.818 0.000 ( +0.0% ) 13.80 14.22 -3.0% 2.374 2.364
2500.131 0.747 0.747 0.000 ( +0.0% ) 17.94 18.17 -1.2% 1.492 1.500
2500.201 2.582 2.582 0.000 ( +0.0% ) 6.46 6.46 -0.0% 5.675 5.675
2500.211 1.736 1.736 0.000 ( +0.0% ) 14.88 15.17 -1.9% 2.359 2.357
2500.212 2.131 2.131 0.000 ( +0.0% ) 12.51 12.38 +1.1% 2.444 2.437
2500.221 2.003 2.003 0.000 ( +0.0% ) 6.63 6.75 -1.7% 2.526 2.529
2500.222 3.378 3.309 0.069 ( +2.1% ) 6.20 6.50 -4.6% 2.617 2.616
2500.223 8.997 8.997 0.000 ( +0.0% ) 2.50 2.54 -1.6% 2.640 2.632
2500.224 6.026 6.026 0.000 ( +0.0% ) 0.59 0.59 -0.4% 2.387 2.372
2500.225 6.058 6.058 0.000 ( +0.0% ) 0.56 0.56 +0.3% 2.445 2.440
2500.226 3.072 3.072 0.000 ( +0.0% ) 6.46 6.52 -0.9% 2.616 2.612
2500.227 1.437 1.437 0.000 ( +0.0% ) 11.67 11.78 -0.9% 1.426 1.434
2500.231 1.408 1.408 0.000 ( +0.0% ) 12.48 12.68 -1.5% 2.250 2.263
2500.232 2.390 2.336 0.054 ( +2.3% ) 11.64 11.88 -2.0% 2.359 2.348
2500.233 4.783 4.783 0.000 ( +0.0% ) 4.09 4.15 -1.3% 2.362 2.360
2500.234 3.648 3.648 0.000 ( +0.0% ) 0.75 0.76 -0.6% 2.143 2.140
2500.235 3.667 3.667 0.000 ( +0.0% ) 0.72 0.73 -0.7% 2.184 2.195
2500.236 2.180 2.180 0.000 ( +0.0% ) 12.14 12.61 -3.7% 2.355 2.354
2500.237 1.016 1.016 0.000 ( +0.0% ) 17.08 17.28 -1.2% 1.443 1.447
2500.241 9.404 9.404 0.000 ( +0.0% ) 3.68 3.79 -3.1% 1.917 1.921
2500.242 10.331 10.331 0.000 ( +0.0% ) 0.89 0.91 -2.0% 1.705 1.706
2500.243 2.712 2.712 0.000 ( +0.0% ) 8.57 8.86 -3.2% 1.077 1.077
2500.244 485.976 485.976 0.000 ( +0.0% ) 0.55 0.57 -2.8% 1.677 1.671
2500.245 823.202 823.202 0.000 ( +0.0% ) 0.73 0.74 -1.2% 1.658 1.660
2500.901 1.777 1.777 0.000 ( +0.0% ) 20.96 21.79 -3.8% 1.833 1.833
2500.902 1.626 1.626 0.000 ( +0.0% ) 21.86 22.70 -3.7% 1.768 1.770
2500.911 13.995 13.995 0.000 ( +0.0% ) 3.51 3.71 -5.3% 1.099 1.097
2500.912 0.171 0.438 -0.267 ( -61.0% ) 1.49 1.34 +11.2% 0.974 0.974
2500.913 0.110 0.110 0.000 ( +0.0% ) 1.14 1.18 -3.0% 0.981 0.977

@hqucms
Copy link
Contributor

hqucms commented Oct 22, 2024

+1

@hqucms
Copy link
Contributor

hqucms commented Oct 22, 2024

@SanghyunKo Could you please update the PR description with the changes you made later, i.e. #46423 (comment) and #46423 (comment)?

@SanghyunKo
Copy link
Contributor Author

@hqucms no problem, done.

@hqucms
Copy link
Contributor

hqucms commented Oct 22, 2024

@hqucms no problem, done.

Thanks a lot!

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8efc581 into cms-sw:master Oct 22, 2024
13 checks passed
@RSalvatico
Copy link
Contributor

type egamma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants