-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding in slimmed superclusters for EGM efficiency measurements to Mini #42007
base: master
Are you sure you want to change the base?
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42007/35969
|
A new Pull Request was created by @Sam-Harper (Sam Harper) for master. It involves the following packages:
@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type egamma |
Milestone for this pull request has been moved to CMSSW_14_0_X.Please open a backport if it should also go in to CMSSW_13_3_X. |
Milestone for this pull request has been moved to CMSSW_14_1_X. Please open a backport if it should also go in to CMSSW_14_0_X. |
-reconstruction |
assign xpog |
New categories assigned: xpog @vlimant,@hqucms,@ftorrresd you have been requested to review this Pull request/Issue and eventually sign? Thanks |
Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X. |
ping (to make bot change milestone) |
Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X. |
PR description:
There is a current push for getting rid of AOD and expand miniAOD with the missing features for needed workflows. One such workflow is the EG reco efficiency measurement which measures the supercluster -> electron efficiency
To do this we need an unbiased collection of superclusters which is only in the AOD as the mini collection is only for SC which are photons or electrons and have some selection on them. We also need to apply some sort of ID on those objects, currently this is track isolation. The track isolation can be calculated on the fly from candidates in the miniAOD but its easier to have it precomputed.
For the EGM efficiency measurement we just need to know the energy/eta/phi of the SC and its track isolation value. It would also be useful to have the rawEnergy and the seed det ids of its clusters (this is absolutely necessary for the seed cluster, useful for the others). Thus we dont need the "full fat" supercluster so a reduced format has been created which will singificantly reduce the size stored
This is a SlimmedSuperCluster, the name can be changed but this is the general idea. Also I'm debating having a vector of floats for the id variables rather than a hardcoded trkIso (ala pat::UserFloats and similar) which if its affordable would improve flexablity.
This is a work in progress and at this stage is here so EGamma experts can comment on it while the rest of the tests are done.
This superseeds #41745 (and in takes much of the inspiration on the track isolation calculator from there)
PR validation:
PR is ongoing. For a RelVal TTBar PU 13_2_0_pre1 sample reminied ,
further size tests are on going.