-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up deprecated edm::RefToBase list 1 for RNTuple #43055
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43055/37255
|
A new Pull Request was created by @jeongeun (JeongEun Lee) for master. It involves the following packages:
@civanch, @mdhildreth, @jfernan2, @mandrenguyen, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d988c/35270/summary.html Comparison SummarySummary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@@ -302,7 +302,6 @@ | |||
<class name="std::vector<Measurement1D>"/> | |||
|
|||
<!-- RefToBase stuff --> | |||
<class name="edm::RefToBase<reco::BaseTagInfo>" /> | |||
<class name="edm::reftobase::BaseHolder<reco::BaseTagInfo>" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR was incomplete. All these ::reftobase::
dictionaries should be cleaned up as well. Could you do that?
PR description:
This pull request is the first update to address the opened issue #42737 :
ROOT is eventually deprecating the current TTree data storage in favor of their new
RNTuple
. TheRNTuple
is not planned to support dynamic polymorphism. One such use case in our data formats isedm::RefToBase<T>
that internally uses dynamic-polymorphism based type erasure. The straightforward migration path is towardsedm::Ptr<T>
, but there are also many cases where the use ofedm::RefToBase<T>
could be cleaned up.This PR covers the first case on the list in the issue #42737.
It contains the set of deprecated
edm::RefToBase
that only dictionary declaration and/or type aliases and/or commented-out code, otherwise unused case.All of these can be easily removed without any impact.
PR validation:
Tested in CMSSW_13_3_0_pre3, the basic test passed in the CMSSW PR instructions