Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up deprecated edm::RefToBase list 1 for RNTuple #43055

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

jeongeun
Copy link
Contributor

PR description:

This pull request is the first update to address the opened issue #42737 :

ROOT is eventually deprecating the current TTree data storage in favor of their new RNTuple. The RNTuple is not planned to support dynamic polymorphism. One such use case in our data formats is edm::RefToBase<T> that internally uses dynamic-polymorphism based type erasure. The straightforward migration path is towards edm::Ptr<T>, but there are also many cases where the use of edm::RefToBase<T> could be cleaned up.

This PR covers the first case on the list in the issue #42737.
It contains the set of deprecated edm::RefToBase that only dictionary declaration and/or type aliases and/or commented-out code, otherwise unused case.
All of these can be easily removed without any impact.

PR validation:

Tested in CMSSW_13_3_0_pre3, the basic test passed in the CMSSW PR instructions

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43055/37255

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

  • DataFormats/BTauReco (reconstruction)
  • DataFormats/Candidate (reconstruction)
  • DataFormats/EgammaCandidates (reconstruction)
  • DataFormats/EgammaReco (reconstruction)
  • DataFormats/MuonSeed (reconstruction)
  • DataFormats/ParticleFlowReco (reconstruction)
  • DataFormats/TauReco (reconstruction)
  • SimDataFormats/TrackingHit (simulation)

@civanch, @mdhildreth, @jfernan2, @mandrenguyen, @cmsbuild can you please review it and eventually sign? Thanks.
@mbluj, @Senphy, @ram1123, @varuns23, @azotz, @andrzejnovak, @JanFSchulte, @Ming-Yan, @Prasant1993, @apsallid, @sobhatta, @andrea21z, @mtosi, @youyingli, @demuller, @missirol, @AlexDeMoor, @Sam-Harper, @CeliaFernandez, @gpetruc, @lgray, @HuguesBrun, @VourMa, @bsunanda, @fabiocos, @rovere, @emilbols, @VinInn, @AnnikaStein, @jainshilpi, @hatakeyamak, @sameasy, @cericeci, @a-kapoor, @afiqaize, @JyothsnaKomaragiri, @trocino, @mmusich, @jhgoh, @abbiendi, @Fedespring this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d988c/35270/summary.html
COMMIT: 6af155e
CMSSW: CMSSW_13_3_X_2023-10-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43055/35270/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 18 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3357400
  • DQMHistoTests: Total failures: 1064
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3356314
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Oct 19, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@@ -302,7 +302,6 @@
<class name="std::vector<Measurement1D>"/>

<!-- RefToBase stuff -->
<class name="edm::RefToBase<reco::BaseTagInfo>" />
<class name="edm::reftobase::BaseHolder<reco::BaseTagInfo>" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was incomplete. All these ::reftobase:: dictionaries should be cleaned up as well. Could you do that?

@makortel makortel mentioned this pull request Oct 27, 2023
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants