clhep: Build with c++17 i.e. default std used for building cmssw

[smuzaffar]

Fixes cms-sw/cmssw#43063

[smuzaffar]

please test

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_3_X/master.

@iarspider, @aandvalenzuela, @smuzaffar can you please review it and eventually sign? Thanks.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here

[smuzaffar]

please test workflow 1.0,2.0 for CMSSW_13_3_ASAN_X

[smuzaffar]

test parameters:

• full_cmssw = true

[smuzaffar]

please test

[cmsbuild]

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f333a/35282/summary.html
COMMIT: b550fc7
CMSSW: CMSSW_13_3_ASAN_X_2023-10-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8772/35282/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 4 errors in the following unit tests:

---> test TestGeneratorInterfacePythia8ConcurrentGeneratorFilter had ERRORS
---> test TestIOMCRandomEngineService had ERRORS
---> test testRecoMETMETProducers had ERRORS
and more ...

RelVals

• 5.15.1_TTbarFS/step1_TTbarFS.log
• 135.4135.4_ZEEFS_13/step1_ZEEFS_13.log
• 2.02.0_ProdTTbar/step1_ProdTTbar.log

Expand to see more relval errors ...

• 25.0
• 1.0
• 1330.0
• 2018.1
• 25202.0
• 10024.0
• 10042.0
• 10224.0
• 10824.0
• 11634.914
• 13234.0
• 14034.0
• 11634.0
• 14234.0
• 11634.911
• 12434.0
• 12434.7
• 12634.0
• 250202.181
• 24834.0
• 25034.999
• 23234.0
• 24834.911

AddOn Tests

• fastsim

[fastsim:1] cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi  --conditions auto:run1_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - elapsed time: 158 sec (ended on Thu Oct 19 17:22:47 2023) - exit: 256

• fastsim1

[fastsim1:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - elapsed time: 153 sec (ended on Thu Oct 19 17:22:46 2023) - exit: 256

• fastsim2

[fastsim2:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - elapsed time: 150 sec (ended on Thu Oct 19 17:22:48 2023) - exit: 256

Expand to see more addon errors ...

• hlt_mc_Fake
• hlt_mc_Fake
• hlt_mc_Fake
• hlt_mc_Fake1
• hlt_mc_Fake1
• hlt_mc_Fake1
• hlt_mc_Fake2
• hlt_mc_Fake2
• hlt_mc_Fake2
• hlt_mc_GRun
• hlt_mc_GRun
• hlt_mc_GRun
• hlt_mc_HIon
• hlt_mc_HIon
• hlt_mc_HIon
• hlt_mc_PIon
• hlt_mc_PIon
• hlt_mc_PIon
• hlt_mc_PRef
• hlt_mc_PRef
• hlt_mc_PRef

[cmsbuild]

Pull request #8772 was updated.

[smuzaffar]

please test workflow 1.0,2.0 for CMSSW_13_3_ASAN_X

[cmsbuild]

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f333a/35298/summary.html
COMMIT: 4cf8917
CMSSW: CMSSW_13_3_ASAN_X_2023-10-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8772/35298/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @aandvalenzuela Fixing warning on hgtopo[i] uninitialized (SimGeneral/Debugging) in SKYLAKEAVX512 IBs cmssw#43038
• @bsunanda Phase2-hgx346Z Modify the tester for parameter and a few scripts to test HGCal geometry cmssw#43039
• @cms-tau-pog Store tau decay products in new nanoAOD table cmssw#42987
• @Dr15Jones Removed std::iterator use from DataFormats/Common cmssw#43029
• @civanch SIM: adopt cmssw for future Geant4 cmssw#43048
• @bsunanda Run3-sim149Z Update the cfg files in SimG4Core/PrintGeomInfo/test/python to avoid depreciated modules cmssw#43049
• @jeongeun Clean up deprecated edm::RefToBase list 1 for RNTuple cmssw#43055
• @jfernan2 Remove deprecated std::iterator from MagneticField/Interpolation/src/bstream_iterator.h cmssw#43044
• @smuzaffar Fix build errors when compiled with -O0 cmssw#43030
• @makortel Add more tests for cmsRun argument parsing cmssw#43035
• @fwyzard Add the ASSERT_DEVICE_MATCHES_HOST_COLLECTION macro cmssw#43041

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f333a/35298/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f333a/35298/git-merge-result

Unit Tests

I found 3 errors in the following unit tests:

---> test TestDQMOnlineClient-hcal_dqm_sourceclient had ERRORS
---> test TestFWCoreSkeletons had ERRORS
---> test TestCondFormatsJetMETObjectsJetCorrectorParameters had ERRORS

RelVals

The relvals timed out after 4 hours.

[smuzaffar]

+externals

this fixes the ASAN failed relvals/addon/unittests.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_3_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[smuzaffar]

please test

lets run tests for production release

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f333a/35306/summary.html
COMMIT: 4cf8917
CMSSW: CMSSW_13_3_X_2023-10-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8772/35306/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 179 lines from the logs
• Reco comparison results: 24 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3357400
• DQMHistoTests: Total failures: 1067
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3356311
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[smuzaffar]

+externals