Fixing warning on `hgtopo[i]` uninitialized (`SimGeneral/Debugging`) in SKYLAKEAVX512 IBs #43038

aandvalenzuela · 2023-10-17T14:04:04Z

Hello,

Conditionally initializing hgtopo[2] (https://github.com/cms-sw/cmssw/blob/master/SimGeneral/Debugging/plugins/CaloParticleDebugger.cc#L310-L311) leads to a warning in SKYLAKEAVX512 IBs (module SimGeneral/Debugging):

/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/f7e55b54829c1b9a76c39d00d5ff27d3/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_13_3_SKYLAKEAVX512_X_2023-10-15-2300/src/SimGeneral/Debugging/plugins/CaloParticleDebugger.cc: In member function 'fillSimHits':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/f7e55b54829c1b9a76c39d00d5ff27d3/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_13_3_SKYLAKEAVX512_X_2023-10-15-2300/src/SimGeneral/Debugging/plugins/CaloParticleDebugger.cc:314:17: warning: 'hgtopo' may be used uninitialized [-Wmaybe-uninitialized]
   314 |     if (hgtopo[i])
      |                 ^
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/f7e55b54829c1b9a76c39d00d5ff27d3/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_13_3_SKYLAKEAVX512_X_2023-10-15-2300/src/SimGeneral/Debugging/plugins/CaloParticleDebugger.cc:291:24: note: 'hgtopo' declared here
  291 |   const HGCalTopology* hgtopo[3];
      |                        ^
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/f7e55b54829c1b9a76c39d00d5ff27d3/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_13_3_SKYLAKEAVX512_X_2023-10-15-2300/src/SimGeneral/Debugging/plugins/CaloParticleDebugger.cc: In member function 'fillSimHits':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/f7e55b54829c1b9a76c39d00d5ff27d3/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_13_3_SKYLAKEAVX512_X_2023-10-15-2300/src/SimGeneral/Debugging/plugins/CaloParticleDebugger.cc:314:17: warning: 'hgtopo' may be used uninitialized [-Wmaybe-uninitialized]
   314 |     if (hgtopo[i])
      |                 ^
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/f7e55b54829c1b9a76c39d00d5ff27d3/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_13_3_SKYLAKEAVX512_X_2023-10-15-2300/src/SimGeneral/Debugging/plugins/CaloParticleDebugger.cc:291:24: note: 'hgtopo' declared here
  291 |   const HGCalTopology* hgtopo[3];
      |                        ^

I suggest initialize it to nullptr when no needed. Feel free to suggest any other option since I am not fully familiar with the module implementation.

Many thanks,
Andrea

cmsbuild · 2023-10-17T14:13:40Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43038/37220

This PR adds an extra 16KB to repository

cmsbuild · 2023-10-17T14:14:07Z

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for master.

It involves the following packages:

SimGeneral/Debugging (simulation)

@mdhildreth, @cmsbuild, @civanch can you please review it and eventually sign? Thanks.
@slomeo, @fabiocos this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

aandvalenzuela · 2023-10-17T14:16:46Z

please test for CMSSW_13_3_SKYLAKEAVX512_X

cmsbuild · 2023-10-17T15:37:32Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-51f94a/35225/summary.html
COMMIT: 96a015c
CMSSW: CMSSW_13_3_SKYLAKEAVX512_X_2023-10-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43038/35225/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

250202.181

----- Begin Fatal Exception 17-Oct-2023 17:02:26 CEST-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/relval/CMSSW_10_6_0/RelValMinBias_13/GEN-SIM/106X_upgrade2018_realistic_v4-v1/10000/48654250-08E9-1D43-AE35-5DF5D6101B2F.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://cms-xrd-global.cern.ch//eos/cms/store/relval/CMSSW_10_6_0/RelValMinBias_13/GEN-SIM/106X_upgrade2018_realistic_v4-v1/10000/48654250-08E9-1D43-AE35-5DF5D6101B2F.root
      [b] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_10_6_0/RelValMinBias_13/GEN-SIM/106X_upgrade2018_realistic_v4-v1/10000/48654250-08E9-1D43-AE35-5DF5D6101B2F.root
      [c] Input file root://xrootd-cms.infn.it//store/relval/CMSSW_10_6_0/RelValMinBias_13/GEN-SIM/106X_upgrade2018_realistic_v4-v1/10000/48654250-08E9-1D43-AE35-5DF5D6101B2F.root could not be opened.
      [d] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/relval/CMSSW_10_6_0/RelValMinBias_13/GEN-SIM/106X_upgrade2018_realistic_v4-v1/10000/48654250-08E9-1D43-AE35-5DF5D6101B2F.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.�
' (errno=3011, code=400). No additional data servers were found.
      [e] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/relval/CMSSW_10_6_0/RelValMinBias_13/GEN-SIM/106X_upgrade2018_realistic_v4-v1/10000/48654250-08E9-1D43-AE35-5DF5D6101B2F.root?tried=+1213llrxrd-redir.in2p3.fr,&xrdcl.requuid=990db191-d24f-4aba-932f-aff801170604
      [f] Problematic data server: cms-xrd-global.cern.ch:1094
      [g] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

12634.0

----- Begin Fatal Exception 17-Oct-2023 17:12:24 CEST-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/relval/CMSSW_13_0_10/RelValMinBias_14TeV/GEN-SIM/130X_mcRun3_2023_realistic_withEarly2023BS_v1_2023-v1/2590000/229b0d73-e551-478c-a840-dad1e6b632c1.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://cms-xrd-global.cern.ch//eos/cms/store/relval/CMSSW_13_0_10/RelValMinBias_14TeV/GEN-SIM/130X_mcRun3_2023_realistic_withEarly2023BS_v1_2023-v1/2590000/229b0d73-e551-478c-a840-dad1e6b632c1.root
      [b] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_13_0_10/RelValMinBias_14TeV/GEN-SIM/130X_mcRun3_2023_realistic_withEarly2023BS_v1_2023-v1/2590000/229b0d73-e551-478c-a840-dad1e6b632c1.root
      [c] Input file root://xrootd-cms.infn.it//store/relval/CMSSW_13_0_10/RelValMinBias_14TeV/GEN-SIM/130X_mcRun3_2023_realistic_withEarly2023BS_v1_2023-v1/2590000/229b0d73-e551-478c-a840-dad1e6b632c1.root could not be opened.
      [d] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/relval/CMSSW_13_0_10/RelValMinBias_14TeV/GEN-SIM/130X_mcRun3_2023_realistic_withEarly2023BS_v1_2023-v1/2590000/229b0d73-e551-478c-a840-dad1e6b632c1.root', flags=0x10, permissions=0660) => error '[ERROR] Operation expired' (errno=0, code=206). No additional data servers were found.
      [e] Last URL tried: root://eoscms.cern.ch:1094//store/relval/CMSSW_13_0_10/RelValMinBias_14TeV/GEN-SIM/130X_mcRun3_2023_realistic_withEarly2023BS_v1_2023-v1/2590000/229b0d73-e551-478c-a840-dad1e6b632c1.root?tried=&xrdcl.requuid=e0075990-08f5-4242-8efd-d2c479e8e240
      [f] Problematic data server: eoscms.cern.ch:1094
      [g] Disabled source: cms-xrd-global.cern.ch:1094
      [h] Disabled source: eoscms.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

aandvalenzuela · 2023-10-18T06:45:57Z

please test for CMSSW_13_3_SKYLAKEAVX512_X

cmsbuild · 2023-10-18T14:57:18Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-51f94a/35241/summary.html
COMMIT: 96a015c
CMSSW: CMSSW_13_3_SKYLAKEAVX512_X_2023-10-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43038/35241/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 78 lines from the logs
Reco comparison results: 73500 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3356920
DQMHistoTests: Total failures: 158143
DQMHistoTests: Total nulls: 277
DQMHistoTests: Total successes: 3198478
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -1.7710000000000004 KiB( 49 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.181 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 12634.0 ): 0.176 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 141.044 ): 0.008 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 250202.181 ): -0.891 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): 0.435 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): 3.521 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 8.0 ): -4.839 KiB SiStrip/MechanicalView
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: found differences in 20 / 48 workflows

civanch · 2023-10-18T16:09:18Z

+1

cmsbuild · 2023-10-18T16:09:41Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

civanch · 2023-10-18T16:10:53Z

There is no regression but I would expect that it is not connected with this fix.

rappoccio · 2023-10-19T15:29:38Z

+1

Errors seem unrelated to this PR

initialize hgtopo[2] to null pointer

96a015c

cmsbuild added this to the CMSSW_13_3_X milestone Oct 17, 2023

cmsbuild added simulation-pending pending-signatures tests-pending orp-pending code-checks-pending labels Oct 17, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 17, 2023

cmsbuild added tests-started and removed tests-pending labels Oct 17, 2023

cmsbuild added tests-rejected and removed tests-started labels Oct 17, 2023

cmsbuild added tests-started and removed tests-rejected labels Oct 18, 2023

cmsbuild added tests-approved and removed tests-started labels Oct 18, 2023

cmsbuild added simulation-approved fully-signed and removed simulation-pending pending-signatures labels Oct 18, 2023

cmsbuild added orp-approved and removed orp-pending labels Oct 19, 2023

cmsbuild merged commit df8bb6a into cms-sw:master Oct 19, 2023

This was referenced Oct 19, 2023

Update CUDA to support Pascal, Volta, Turing, Ampere and Lovelace GPUs cms-sw/cmsdist#8767

Merged

[do not merge][ASAN] Build with -O0 flag cms-sw/cmsdist#8761

Closed

clhep: Build with c++17 i.e. default std used for building cmssw cms-sw/cmsdist#8772

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing warning on `hgtopo[i]` uninitialized (`SimGeneral/Debugging`) in SKYLAKEAVX512 IBs #43038

Fixing warning on `hgtopo[i]` uninitialized (`SimGeneral/Debugging`) in SKYLAKEAVX512 IBs #43038

aandvalenzuela commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

aandvalenzuela commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

aandvalenzuela commented Oct 18, 2023

cmsbuild commented Oct 18, 2023

civanch commented Oct 18, 2023

cmsbuild commented Oct 18, 2023

civanch commented Oct 18, 2023

rappoccio commented Oct 19, 2023

Fixing warning on hgtopo[i] uninitialized (SimGeneral/Debugging) in SKYLAKEAVX512 IBs #43038

Fixing warning on hgtopo[i] uninitialized (SimGeneral/Debugging) in SKYLAKEAVX512 IBs #43038

Conversation

aandvalenzuela commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

aandvalenzuela commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

RelVals

aandvalenzuela commented Oct 18, 2023

cmsbuild commented Oct 18, 2023

Comparison Summary

civanch commented Oct 18, 2023

cmsbuild commented Oct 18, 2023

civanch commented Oct 18, 2023

rappoccio commented Oct 19, 2023

Fixing warning on `hgtopo[i]` uninitialized (`SimGeneral/Debugging`) in SKYLAKEAVX512 IBs #43038

Fixing warning on `hgtopo[i]` uninitialized (`SimGeneral/Debugging`) in SKYLAKEAVX512 IBs #43038