Remove deprecated std::iterator from MagneticField/Interpolation/src/bstream_iterator.h

[jfernan2]

PR description:

Addressing issue #43009

This PR removes the C++17 deprecated std::iterator in MagneticField/Interpolation/src/bstream_iterator.h in favor of the explicit declaration of the five iterator traits, as suggested by the link posted in the original issue.

@makortel I would appreciate your feedback on whether this is the correct approach/solution to the issue.
PR validation:

Code compiles.
Completed successfully the tests from scram b runtests
Backport:

Not a backport, no backport needed

[jfernan2]

resolves #43009

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43044/37234

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

• MagneticField/Interpolation (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@namapane this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-211bde/35233/summary.html
COMMIT: 32a30c9
CMSSW: CMSSW_13_3_X_2023-10-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43044/35233/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 2988 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3357400
• DQMHistoTests: Total failures: 6126
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3351252
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: found differences in 1 / 48 workflows

[jfernan2]

I realize now that this file is not used/referenced anywhere in CMSSW, so it may be deprecated since scram b and usual tests do not complain of its absence. So we think this file may be safely removed

[makortel]

I would appreciate your feedback on whether this is the correct approach/solution to the issue.

The changes look correct, but ...

So we think this file may be safely removed

... I agree the file looks unused, and I agree it could be removed. Thanks!

[jfernan2]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43044/37241

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #43044 was updated. @mandrenguyen, @jfernan2 can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-211bde/35243/summary.html
COMMIT: 1082ae1
CMSSW: CMSSW_13_3_X_2023-10-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43044/35243/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 15 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3357400
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3357366
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1