fix out of bound error in Phase-2 L1 Calorimeter barrel emulator

[skkwan]

This PR addresses the out-of-bounds error in Phase2L1RCT.h raised in #46372.

PR description:

This PR addresses the out-of-bounds error in Phase2L1RCT.h raised in #46372.

PR validation:

The original emulator has been re-run and checked that the outputs are unchanged.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46472/42330

• There are other open Pull requests which might conflict with changes you have proposed:
  • File L1Trigger/L1CaloTrigger/interface/Phase2L1RCT.h modified in PR(s): [UBSAN][L1] Fix read out of bounds issue #46372

[cmsbuild]

A new Pull Request was created by @skkwan for master.

It involves the following packages:

• L1Trigger/L1CaloTrigger (l1, upgrade)

@Moanwar, @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[skkwan]

Hi @smuzaffar, this PR should be for the master branch.

Thanks,
Stephanie

[smuzaffar]

please test

[smuzaffar]

test parameters:

• workflow = 23634.0

[smuzaffar]

please test for CMSSW_14_2_UBSAN_X

[cmsbuild]

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7ea35/42337/summary.html
COMMIT: 12501e2
CMSSW: CMSSW_14_2_X_2024-10-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46472/42337/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @SanghyunKo Adding unbiased superclusters to miniAOD and EGM nano #46423
• @trackreco Tracking validation updates/improvements #46324

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7ea35/42337/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7ea35/42337/git-merge-result

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 465 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3566331
• DQMHistoTests: Total failures: 84267
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3482044
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 201 log files, 171 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7ea35/42338/summary.html
COMMIT: 12501e2
CMSSW: CMSSW_14_2_UBSAN_X_2024-10-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46472/42338/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @SanghyunKo Adding unbiased superclusters to miniAOD and EGM nano #46423
• @trackreco Tracking validation updates/improvements #46324

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7ea35/42338/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7ea35/42338/git-merge-result

[smuzaffar]

please test

lets rerun the default tests based on newer IB

[smuzaffar]

UBSAN test shows that L1Trigger/L1CaloTrigger/interface/Phase2L1RCT.h:1257:24: runtime error: index 25 out of bounds for type 'ap_uint [24]' is gone/fixed

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7ea35/42349/summary.html
COMMIT: 12501e2
CMSSW: CMSSW_14_2_X_2024-10-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46472/42349/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 47
• DQMHistoTests: Total histograms compared: 3665145
• DQMHistoTests: Total failures: 510
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3664615
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
• Checked 206 log files, 175 edm output root files, 47 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46472/42391

[cmsbuild]

Pull request #46472 was updated. @Moanwar, @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please check and sign again.

[aloeliger]

please test

[srimanob]

@cmsbuild abort

[srimanob]

@cmsbuild please test

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7ea35/42561/summary.html
COMMIT: 091bcb1
CMSSW: CMSSW_14_2_X_2024-11-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46472/42561/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 47
• DQMHistoTests: Total histograms compared: 3668383
• DQMHistoTests: Total failures: 531
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3667832
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
• Checked 206 log files, 175 edm output root files, 47 DQM output files
• TriggerResults: no differences found

[Moanwar]

+Upgrade

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1