Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.1.X] AlcaPCCEventProducer configuration to save per ROC data #46249

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 4, 2024

backport of #46231

PR description:

A minor change to the AlcaPCCEventProducer

The proposed modification would enable external configuration of the producer. This would allow us to specify, via a menu, whether we want to save pixel data at per-module or per-ROC granularity.

This feature is particularly important for special fills where we have high-rate zero-bias streams for AlcaLumi. The proposed change could reduce event size by a factor of ~7 under these conditions compared to the current implementation. It is essential to have this feature for successful pp-Ref and HI vdM fills planned in the next weeks.

However, per-ROC information is critical for physics, as it helps us understand instabilities and non-linearities within individual modules, and we wish to continue recording this data. More details are given in the talk by B. Kronheim and C. Palmer.

This PR is related to #29069 #44996

PR validation:

See master PR

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #46231 for PPref and HIon 2024 run data-taking purposes

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2024

A new Pull Request was created by @mmusich for CMSSW_14_1_X.

It involves the following packages:

  • Calibration/LumiAlCaRecoProducers (alca)

@atpathak, @cmsbuild, @consuegs, @perrotta can you please review it and eventually sign? Thanks.
@mmusich, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Oct 4, 2024

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Oct 4, 2024

urgent

  • please include this in the next 14.1.X release

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53ced7/41956/summary.html
COMMIT: 85804f2
CMSSW: CMSSW_14_1_X_2024-10-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46249/41956/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

perrotta commented Oct 4, 2024

+1

  • The update is straightforward, I can sign even without waiting for the results of the tests in the IB where the master version of this PR was merged

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ffd3756 into cms-sw:CMSSW_14_1_X Oct 5, 2024
9 checks passed
@mmusich mmusich deleted the duff-ae_pcc-per-roc-lumi_14_1_X branch October 5, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants