Including per ROC histograms for Pixel Cluster Counting luminosity

[duff-ae]

PR description:

The modules affected:
Calibration/LumiAlCaRecoProducers
DataFormats/Luminosity

Including extra loops to AlcaPCCEventProducer to iterate over clusters and sort them by corresponding ROC modules. Later the information is used to produce luminosity histograms (per bx) with per ROC granularity at HLT. This information could be used to identify the outliers and improve the stability and linearity of Pixel Cluster Counting luminosity (talk by B. Kronheim and C. Palmer https://indico.cern.ch/event/1358674/contributions/5725781/attachments/2775100/4836057/PCC_Active_Masking_Dec_19_2023.pdf)

The proposed future is validated following the official guideline http://cms-sw.github.io/PRWorkflow.html

• scram b runtests
• runTheMatrix.py -l limited -i all --ibeos:
  • Thu May 16 23:08:02 2024; exit: 0 0 0 47 46 44 35 18 1 1 1 1 1 1 tests passed, 0 0 1 0 0 0 0 0 0 0 0 failed
    Also by running test reconstruction on raw data

Related PR:
#29069

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44996/40280

• This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44996/40280/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44996/40280/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44996/40281

• This PR adds an extra 32KB to repository

[cmsbuild]

Pull request #44996 was updated. @perrotta, @consuegs, @jfernan2, @mandrenguyen, @saumyaphor4252 can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb8465/39433/summary.html
COMMIT: 1f3834c
CMSSW: CMSSW_14_1_X_2024-05-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44996/39433/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338976
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338950
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1

[perrotta]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1

[francescobrivio]

@duff-ae @cms-sw/alca-l2 do we need a backport for data-taking of this PR?

[capalmer85]

It would be nice to backport. Yes please

[francescobrivio]

@duff-ae @cms-sw/alca-l2 are you going to take care of creating the backport?

[perrotta]

Backport prepared in #45054

[davidlange6]

This PR is the apparent cause of #45306
(adding some GBs of RSS)

[mmusich]

type changes-dataformats