PCC Event Producer 11_1_X target

[samhiggie]

PR description:
Continuation of PR #28807
and rebase of PR #28992 - will close after verification

Changed some of the names of the producers to match the nomenclature by most modules in cmssw.

Added a fillDescription method so that the new AlCaPCCEventProducer may be added to the HLT configuration

Removed a PSet formatting

PR validation:
Compiles and Runs with local test files and HLT configuration like:
hltGetConfiguration /users/sharper/2019/alca/alcaLumi --setup /dev/CMSSW_10_6_0/GRun/V3 --globaltag auto:run2_hlt_GRun --unprescale > hlt.py
(must replace AlcaPCCProducer with AlcaPCCEventProducer)
FastReport Info:

FastReport CPU time sched. / depend. Real time sched. / depend. Alloc. sched. / depend. Dealloc. sched. / depend. Processes and Paths
FastReport 3.4 ms 3.4 ms 6.3 ms 6.3 ms +3333 kB +3333 kB -3081 kB -3081 kB Alca_LumiPixelsCounts_ZeroBias_v1
FastReport 0.0 ms 0.0 ms 0.1 ms 0.1 ms +0 kB +0 kB +0 kB +0 kB Alca_LumiPixelsCounts_Random_v1

[cmsbuild]

@samhiggie, CMSSW_11_1_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

The code-checks are being triggered in jenkins.

[samhiggie]

Hello @slava77 , I've successfully rebased on this branch. With no conflicts.

This was frustrating though, as all the commits that I had posted I needed to go through and many contained changes that were not necessary or I changed in order to forget them. In the future, is there a way I can just drop commits that are useless so I don't need to go through each one?
OR if the state of the branch is in good condition is it possible to just sign off on the conflicts?

Thanks for the help!

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29069/13950

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29069/13950/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29069/13950/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[samhiggie]

code formatting suggestions have been applied, thanks @cmsbuild !

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29069/13951

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @samhiggie for master.

It involves the following packages:

Calibration/LumiAlCaRecoProducers
DataFormats/Luminosity

@perrotta, @slava77, @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @rovere, @tocheng this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4975/console Started: 2020/03/03 17:52

[cmsbuild]

+1
Tested at: 1136d16
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-51552a/4975/summary.html
CMSSW: CMSSW_11_1_X_2020-03-03-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-51552a/4975/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2680373
• DQMHistoTests: Total failures: 41
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2680013
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[slava77]

+1

for #29069 1136d16

• changes in reco category are trivial, only in a commented out line in DataFormats/Luminosity/interface/PixelClusterCounts.h
• jenkins tests pass

[pohsun]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1