AlcaPCCEventProducer configuration to save per ROC data #46231
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46231/42043 |
|
A new Pull Request was created by @duff-ae for master. It involves the following packages:
@atpathak, @cmsbuild, @consuegs, @perrotta can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
@cms-sw/hlt-l2 FYI |
| @@ -38,6 +38,7 @@ class AlcaPCCEventProducer : public edm::global::EDProducer<> { | |||
| private: | |||
| const edm::InputTag pixelClusterLabel_; | |||
| const std::string trigstring_; //specifies the trigger Rand or ZeroBias | |||
| bool savePerROCInfo_ = true; // save per ROC data (important for the special fills) | |||
There was a problem hiding this comment.
const bool savePerROCInfo_; as for the other parameters.
| @@ -101,6 +105,7 @@ void AlcaPCCEventProducer::fillDescriptions(edm::ConfigurationDescriptions& desc | |||
| edm::ParameterSetDescription evtParamDesc; | |||
| evtParamDesc.add<edm::InputTag>("pixelClusterLabel", edm::InputTag("siPixelClustersForLumi")); | |||
| evtParamDesc.addUntracked<std::string>("trigstring", "alcaPCCEvent"); | |||
| evtParamDesc.addUntracked<bool>("savePerROCInfo", true); | |||
There was a problem hiding this comment.
Just for my own understanding: since this parameter affects heavily the physics output, should it be a tracked parameter ?
There was a problem hiding this comment.
Thank you, makes perfect sense. I modified the code
cmsbuild
added
tests-pending
code-checks-pending
and removed
tests-started
code-checks-approved
labels
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46231/42048 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
cmsbuild
added
code-checks-rejected
code-checks-pending
and removed
code-checks-pending
code-checks-rejected
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46231/42049 |
|
please test |
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
|
+alca |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
duff-ae
changed the title
|
@perrotta Dear Andrea, Could you please help us with the backport? |
|
urgent |
|
@duff-ae FYI, making a backport is no different from making a PR to master, you just need to start from a different base branch. cmsrel CMSSW_14_1_X_2024-10-03-2300
cd CMSSW_14_1_X_2024-10-03-2300/src/
cmsenv
git cms-addpkg Calibration/LumiAlCaRecoProducers
git cherry-pick e1ffa12420ea08c9d815de625d4ac60d8bb14936
git cherry-pick 8bb4def659b83fb36cce38ddb40f5847c07e0b27
git push my-cmssw +HEAD:pcc-per-roc-lumi_14_1_X(then open the PR as usual) |
|
+1 |
A minor change to the "AlcaPCCEventProducer"
The proposed modification would enable external configuration of the producer. This would allow us to specify, via a menu, whether we want to save pixel data at per-module or per-ROC granularity.
This feature is particularly important for special fills where we have high-rate zero-bias streams for AlcaLumi. The proposed change could reduce event size by a factor of ~7 under these conditions compared to the current implementation. It is essential to have this feature for successful pp-Ref and HI vdM fills planned in the next weeks.
However, per-ROC information is critical for physics, as it helps us understand instabilities and non-linearities within individual modules, and we wish to continue recording this data. More details are given in the talk by B. Kronheim and C. Palmer.
The target release is 14_1
This PR is related to #29069 #44996