rename modifier run3_2024_L1T to stage2L1Trigger_2024

[missirol]

PR description:

This PR suggests to rename the modifier introduced in #45352, in order to use a name that's consistent with other existing modifiers specific to the Stage-2 L1 Trigger, see
https://github.com/cms-sw/cmssw/blob/7320a6bb38b604b8c69c7e1ee57539fe71a53b9e/Configuration/Eras/python/Modifier_stage2L1Trigger_2017_cff.py
https://github.com/cms-sw/cmssw/blob/7320a6bb38b604b8c69c7e1ee57539fe71a53b9e/Configuration/Eras/python/Modifier_stage2L1Trigger_2018_cff.py
https://github.com/cms-sw/cmssw/blob/7320a6bb38b604b8c69c7e1ee57539fe71a53b9e/Configuration/Eras/python/Modifier_stage2L1Trigger_2021_cff.py

PR validation:

None.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

Will be backported down to CMSSW_14_0_X.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45713/41353

[cmsbuild]

A new Pull Request was created by @missirol for master.

It involves the following packages:

• Configuration/Eras (operations)
• L1Trigger/L1TMuonBarrel (l1)

@aloeliger, @antoniovilela, @cmsbuild, @davidlange6, @epalencia, @fabiocos, @mandrenguyen, @rappoccio can you please review it and eventually sign? Thanks.
@AnnikaStein, @JanFSchulte, @Martin-Grunewald, @dinyar, @eyigitba, @fabiocos, @makortel, @mmusich, @thomreis this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

I would suggest to hold this until (at least) #45242 gets merged and after that this one is updated accordingly.

[aloeliger]

@mmusich I am fine with this change to the quick thing I threw together. Do you want to issue an explicit hold on this one or let it go?

[mmusich]

well, I have no specific objection against this, seems just more economical to wait the other (earlier) PR to enter first and then clean-up all the use cases (I don't know if there are other PRs pending that use the same modifier) at the same time.

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

[aloeliger]

+l1

• Fine with the rename, and Unprescaled AXO seeds (L1_AXO_Nominal, L1_AXO_VTight) added to the un… #45242 has been merged

[missirol]

"hold"

I guess I have to rebase in order to take #45242 into account.

Will #45242 be backported to 14_1_X ? I don't have a strong opinion, but I guess it would be clearer to rename this modifier in all affected cycles (14_0_X and higher).

[mmusich]

Will #45242 be backported to 14_1_X ?

done at #45819

I don't have a strong opinion, but I guess it would be clearer to rename this modifier in all affected cycles (14_0_X and higher).

fwiw, I agree

[missirol]

Thanks @mmusich . I'll rebase this one, then open backports once #45805 and #45819 are integrated.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45713/41559

[cmsbuild]

Pull request #45713 was updated. @aloeliger, @antoniovagnerini, @antoniovilela, @cmsbuild, @davidlange6, @epalencia, @fabiocos, @mandrenguyen, @nothingface0, @rappoccio, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c27e5/41178/summary.html
COMMIT: 8003b32
CMSSW: CMSSW_14_2_X_2024-08-27-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45713/41178/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 176 lines from the logs
• Reco comparison results: 77 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3328202
• DQMHistoTests: Total failures: 4592
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3323590
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 191 log files, 161 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[tjavaid]

+1

[antoniovilela]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.