Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] L1T DQM: Combined backport of cms-sw/cmssw#45242 and cms-sw/cmssw#45634 #45805

Merged
merged 4 commits into from
Aug 31, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 27, 2024

PR description:

Combined backport #45242 and #45634:

  • Two Unprescaled AXO seeds, L1_AXO_Nominal and L1_AXO_VTight, added to unprescaled uGT algo shortlist. This aims to add these seeds to uGT algo accept vs BX plots (L1T Online shift plots 19-20).
  • modifies the era in the DQM client config files to fix the data emulator mismatches seen in BMTF Muon quality plots.

PR validation:

Tests at P5 OK: #45242 (comment)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of backport #45242 and #45634 for data-taking operations.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 27, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • DQM/Integration (dqm)
  • DQM/L1TMonitor (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@batinkov, @francescobrivio, @missirol, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 27, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Aug 27, 2024

@cmsbuild, please test

@mmusich mmusich changed the title Combined backport of cms-sw/cmssw#45242 and cms-sw/cmssw#45634 [14.0.X] L1T DQM: Combined backport of cms-sw/cmssw#45242 and cms-sw/cmssw#45634 Aug 27, 2024
@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1e3cb/41152/summary.html
COMMIT: 4119867
CMSSW: CMSSW_14_0_X_2024-08-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45805/41152/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 72 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3343220
  • DQMHistoTests: Total failures: 1222
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3341978
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.624 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): 0.656 KiB L1T/L1TStage2uGT
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Aug 28, 2024

backport #45242

@mmusich
Copy link
Contributor Author

mmusich commented Aug 28, 2024

backport #45634

@tjavaid
Copy link

tjavaid commented Aug 28, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 21e0ec2 into cms-sw:CMSSW_14_0_X Aug 31, 2024
9 checks passed
@mmusich mmusich deleted the mm_wrap_L1T_DQM_update branch August 31, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants