Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Era modifier updated from Run3 to Run3_2024 in dqm client configs #45634

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Era modifier updated from Run3 to Run3_2024 in dqm client configs #45634

merged 1 commit into from
Aug 27, 2024

Conversation

jaisatul
Copy link
Contributor

@jaisatul jaisatul commented Aug 5, 2024 •
edited
Loading

PR description:

This PR modifies the era in the DQM client config files to fix the data emulator mismatches seen in BMTF Muon quality plots.

PR validation:

Code quality check performed. Changes under test with DQM Online streamers

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Aug 5, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45634/41146

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2024

A new Pull Request was created by @jaisatul for master.

It involves the following packages:

  • DQM/Integration (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@batinkov, @francescobrivio, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild cmsbuild mentioned this pull request Aug 9, 2024
Merged
@missirol
Copy link
Contributor

missirol commented Aug 9, 2024

@cms-sw/dqm-l2

What's the plan for this PR ? Sounds like it has some relevance for online operations (fix for spurious warnings in L1T online-DQM).

missirol
missirol reviewed Aug 9, 2024
View reviewed changes
DQM/Integration/python/clients/l1tstage2_dqm_sourceclient-live_cfg.py
from Configuration.Eras.Era_Run3_cff import Run3
process = cms.Process("L1TStage2DQM", Run3)
from Configuration.Eras.Era_Run3_2024_cff import Run3_2024
process = cms.Process("L1TStage2DQM", Run3_2024)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, why is this change needed in this client ? (as opposed to changing only l1tstage2emulator_dqm)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not strictly necessary, but if it doesn't change the functionality I would apply the change. It'll be required if we implement something like this to L1T DQM clients

@tjavaid
Copy link

tjavaid commented Aug 20, 2024

@cms-sw/dqm-l2

What's the plan for this PR ? Sounds like it has some relevance for online operations (fix for spurious warnings in L1T online-DQM).

I see the PR in draft mode. @jaisatul , do we expect another commit or is it ready for a review ?

@eyigitba eyigitba mentioned this pull request Aug 21, 2024
Merged
@jaisatul jaisatul marked this pull request as ready for review August 21, 2024 13:40
@tjavaid
Copy link

tjavaid commented Aug 21, 2024

please test

@cmsbuild
Copy link
Contributor

REMINDER @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela: This PR was tested with #45242, please check if they should be merged together

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-05a237/41065/summary.html
COMMIT: 94e9d46
CMSSW: CMSSW_14_1_X_2024-08-21-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45634/41065/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 2024.2140052024.214005_RunZeroBias2024D_50k/step1_dasquery.log
  • 2024.3000052024.300005_RunBTagMu2024E_50k/step1_dasquery.log
  • 2024.3010052024.301005_RunDisplacedJet2024E_50k/step1_dasquery.log
Expand to see more relval errors ...

Comparison Summary

Summary:

@mmusich
Copy link
Contributor

mmusich commented Aug 23, 2024

@cmsbuild ignore tests-rejected with ib-failure

@mmusich
Copy link
Contributor

mmusich commented Aug 26, 2024

@cms-sw/dqm-l2 can this be signed, given tests at P5 (see #45242 (comment)) are OK?

@tjavaid
Copy link

tjavaid commented Aug 26, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mmusich mmusich mentioned this pull request Aug 27, 2024
Merged
@cmsbuild
Copy link
Contributor

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Aug 27, 2024
@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Aug 27, 2024
@cmsbuild cmsbuild merged commit bbbd522 into cms-sw:master Aug 27, 2024
10 of 11 checks passed
@mmusich mmusich mentioned this pull request Aug 28, 2024
Merged
cmsbuild added a commit that referenced this pull request Aug 31, 2024
@cmsbuild
Merge pull request #45805 from mmusich/mm_wrap_L1T_DQM_update
21e0ec2 
[14.0.X] L1T DQM: Combined backport of #45242 and #45634
@jaisatul jaisatul mentioned this pull request Sep 2, 2024
Closed
cmsbuild added a commit that referenced this pull request Sep 2, 2024
@cmsbuild
Merge pull request #45819 from mmusich/mm_wrap_L1T_DQM_update_14_1_X
b33390a 
[14.1.X]  L1T DQM: Combined backport of #45242 and #45634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyigitba eyigitba eyigitba left review comments

@missirol missirol missirol left review comments

Assignees
No one assigned
Labels
code-checks-approved dqm-approved fully-signed orp-approved tests-approved tests-ib-failure
Projects
None yet
Milestone
CMSSW_14_2_X
Development

Successfully merging this pull request may close these issues.
7 participants
@jaisatul @cmsbuild @missirol @tjavaid @mmusich @mandrenguyen @eyigitba