-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2024 L1T modifier & modifiers for changing BMTF quality calculation #45352
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45352/40771
|
A new Pull Request was created by @aloeliger for master. It involves the following packages:
@aloeliger, @antoniovilela, @cmsbuild, @davidlange6, @epalencia, @fabiocos, @rappoccio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b955f/40177/summary.html
Comparison SummarySummary:
|
+l1 |
urgent |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
This PR adds an Era based modifier to the new BMTF quality calculation introduced by #44432, to allow for use of the old versus new quality calculation in the planned upcoming re-reco + MC campaign. The default is to use the old calculation and for Run3_2024 Eras and beyond to use the new calculation.
As a note, this does introduce a modifier file I have created personally, I don't know if there is a standard for who can create these or when they should be made, and it is introduced to the Run3_2024 era.
@slaurila @eyigitba: FYI
PR validation:
All code compiles and has had formatting applied. The settings+flag has been tested in L1 re-emulation under different eras to trigger the correct quality calculation.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR is not a backport and is not expected to be backported.