Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CICADA-uGT Packer #45826

Merged
merged 4 commits into from
Sep 26, 2024
Merged

CICADA-uGT Packer #45826

merged 4 commits into from
Sep 26, 2024

Conversation

aloeliger
Copy link
Contributor

PR description:

This PR introduces a packer for the CICADA score as received by the uGT system. This should be the counterpart to the unpacker introduced by #45293. A packer for the calorimeter trigger side CICADA information is not included, but will be forthcoming

@eyigitba & @slaurila FYI

PR validation:

All code compiles and has had formatting applied. Testing of the functionality of the packer is currently in progress

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport, but will likely need backporting to 14_0

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 28, 2024

cms-bot internal usage

@aloeliger aloeliger changed the title initial CICADA-uGT packer draft CICADA-uGT Packer Aug 28, 2024
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aloeliger for master.

It involves the following packages:

  • EventFilter/L1TRawToDigi (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @dinyar, @eyigitba, @missirol, @mmusich, @thomreis this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45826/41586

@cmsbuild
Copy link
Contributor

Pull request #45826 was updated. @aloeliger, @antoniovagnerini, @cmsbuild, @epalencia, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

@aloeliger
Copy link
Contributor Author

The CICADA packer has now been tested and producing expected answers on MC (given the emulator score)
image
image

@aloeliger aloeliger marked this pull request as ready for review August 30, 2024 15:56
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #45826 was updated. @aloeliger, @antoniovilela, @cmsbuild, @davidlange6, @epalencia, @fabiocos, @mandrenguyen, @rappoccio can you please check and sign again.

@aloeliger
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e21f5f/41536/summary.html
COMMIT: 33a97a9
CMSSW: CMSSW_14_2_X_2024-09-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45826/41536/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@aloeliger
Copy link
Contributor Author

+l1

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@@ -30,6 +30,7 @@
simGtStage2Digis.JetInputTag = "unpackGtStage2:Jet"
simGtStage2Digis.EtSumInputTag = "unpackGtStage2:EtSum"
simGtStage2Digis.EtSumZdcInputTag = "unpackGtStage2:EtSumZDC"
simGtStage2Digis.CICADAScoreInputTag = "unpackGtStage2:CICADAScore"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aloeliger

when trying to run the L1T emulation in CMSSW_14_2_X I got:

----- Begin Fatal Exception 04-Nov-2024 15:06:01 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named hlt.py
Exception Message:
 unknown python problem occurred.
TypeError: CICADAScoreInputTag does not already exist, so it can only be set to a CMS python configuration type

At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el9_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-03-0000/src/FWCore/ParameterSet/python/Mixins.py(319): __raiseBadSetAttr
  /cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el9_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-03-0000/src/FWCore/ParameterSet/python/Mixins.py(244): __addParameter
  /cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el9_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-03-0000/src/FWCore/ParameterSet/python/Mixins.py(285): __setattr__
  /cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el9_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-03-0000/src/Configuration/StandardSequences/python/SimL1EmulatorRepack_uGT_cff.py(33): <module>
  <frozen importlib._bootstrap>(228): _call_with_frames_removed
  <frozen importlib._bootstrap_external>(850): exec_module
  <frozen importlib._bootstrap>(695): _load_unlocked
  <frozen importlib._bootstrap>(986): _find_and_load_unlocked
  <frozen importlib._bootstrap>(1007): _find_and_load
  /cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el9_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-03-0000/src/FWCore/ParameterSet/python/Config.py(762): load
  /cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el9_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-03-0000/src/HLTrigger/Configuration/python/CustomConfigs.py(178): L1REPACK
  hlt.py(31207): <module>

----- End Fatal Exception -------------------------------------------------

I fixed it at #46597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants