-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0.X] double precision in StandaloneTrackMonitor
and TrackTypeMonitor
plots to avoid numerical overflow with high number of bin counts
#45315
Conversation
…verflow with high number of bin counts
…w with high number of bin counts
A new Pull Request was created by @mmusich for CMSSW_14_0_X. It involves the following packages:
@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
cms-bot internal usage |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-550183/40098/summary.html Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
hold |
Pull request has been put on hold by @mmusich |
Pull request #45315 was updated. @antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again. |
unhold |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-550183/40117/summary.html Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #45325
backport of #45225
PR description:
The goal of this PR is to circumvent the issue reported at #45183.
In data/MC comparisons for tracking we were hit by the limits of
TH1F
numerical precision. Histograms with more than around 1e7 entries in a bin will stop accumulation in that bin (because within numerical precisionx + 1. == x
).This PR changes the booking of
StandaloneTrackMonitor
andTrackTypeMonitor
plots, from usingbook1D
tobook1DD
in order to use double precision in bin content accumulation.To limit the amount of changes in the tracking monitor classes a new overloaded
book1DD
method is added toDQMStore
in order to be able to use theTH1D
constructor of the type that creates a 1-Dim histogram with variable bins of typedouble
:TH1D (const char *name, const char *title, Int_t nbinsx, const Float_t *xbins)
PR validation:
cmssw
compiles.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #45325 and #45225 to CMSSW_14_0_X for convenience of usage in 2024 data.