Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need for automatic detection of numerical underflows in histograms #45183

Open
slava77 opened this issue Jun 10, 2024 · 4 comments
Open

need for automatic detection of numerical underflows in histograms #45183

slava77 opened this issue Jun 10, 2024 · 4 comments

Comments

@slava77
Copy link
Contributor

slava77 commented Jun 10, 2024

In data/MC comparisons for tracking we were hit by the limits of TH1F numerical precision.
Histograms with more than around 1e7 entries in a bin will stop accumulation in that bin (because within numerical precision x + 1. == x).

It may be useful to have a generic feature in MonitorElement or DQMAnalyzers to e.g. once per lumi (or more often) to check if the histograms have any bins with entries that would underflow a fill (with some configurable weight; default of 1).
The same could be done per Fill call, but it could be a bit expensive CPU-wise.

@cms-sw/dqm-l2
@dbruschi

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 10, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

A new Issue was created by @slava77.

@Dr15Jones, @sextonkennedy, @rappoccio, @smuzaffar, @antoniovilela, @makortel can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor

assign dqm

@cmsbuild
Copy link
Contributor

New categories assigned: dqm

@rvenditti,@syuvivida,@tjavaid,@nothingface0,@antoniovagnerini you have been requested to review this Pull request/Issue and eventually sign? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants