-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
double precision in StandaloneTrackMonitor
and TrackTypeMonitor
plots to avoid numerical overflow with high number of bin counts
#45225
double precision in StandaloneTrackMonitor
and TrackTypeMonitor
plots to avoid numerical overflow with high number of bin counts
#45225
Conversation
…verflow with high number of bin counts
…w with high number of bin counts
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45225/40592
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@rvenditti, @tjavaid, @cmsbuild, @nothingface0, @antoniovagnerini, @syuvivida can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee538c/39891/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The goal of this PR is to circumvent the issue reported at #45183.
In data/MC comparisons for tracking we were hit by the limits of
TH1F
numerical precision. Histograms with more than around 1e7 entries in a bin will stop accumulation in that bin (because within numerical precisionx + 1. == x
).This PR changes the booking of
StandaloneTrackMonitor
andTrackTypeMonitor
plots, from usingbook1D
tobook1DD
in order to use double precision in bin content accumulation.To limit the amount of changes in the tracking monitor classes a new overloaded
book1DD
method is added toDQMStore
in order to be able to use theTH1D
constructor of the type that creates a 1-Dim histogram with variable bins of typedouble
:TH1D (const char *name, const char *title, Int_t nbinsx, const Float_t *xbins)
PR validation:
cmssw
compiles.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but it might be backported for convenience if validation is positive.