-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix overloaded book1DD
method in DQMStore
#45325
Conversation
type bug-fix |
cms-bot internal usage |
@cmsbuild, please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45325/40743
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@antoniovagnerini, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0e02e/40118/summary.html
Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
a backport of this (#45315) was already merged. Why this is not signed yet? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is a bugfix for the commit 0864545 introduced in #45225 (thanks to @rubenforti for spotting).
PR validation:
Run the unit tests (
scram b runtests_testTrackingDATAMC
) of theDQM/TrackingMonitorSource
and looked at ME-s booked with the overloaded method and checked it is aTH1D
indeed.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but it will be backported at #45315.