Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add track-to-track monitoring of HLT GSF electron tracks with respect to offline #44868

Merged
merged 4 commits into from
May 9, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 29, 2024

PR description:

Title says it all, supports track-to-track monitoring of HLT GSF electron tracks with respect to offline for both Run 3 (hltEgammaGsfTracks) and Phase 2 (hltEgammaGsfTracksL1Seeded).
In addition:

  • add regular GSF tracking monitoring at HLT also in Phase-2;
  • fix a bug in the vertex collection used for egmTrackingMonHLT

PR validation:

Run successfully both runTheMatrix.py -l 13034.0 -t 4 -j 8 (Run 3) and runTheMatrix.py -l 24834.0 -t 4 -j 8 (Phase 2) and observed the corresponding monitoring elements filled.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but it will be backported to CMSSW_14_0_X for data-taking purposes.

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Apr 29, 2024
@mmusich
Copy link
Contributor Author

mmusich commented Apr 29, 2024

cc:

@RSalvatico @swagata87

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 29, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44868/40120

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Configuration/EventContent (operations)
  • DQM/TrackingMonitorSource (dqm)
  • DQMOffline/Trigger (dqm)

@fabiocos, @cmsbuild, @antoniovagnerini, @syuvivida, @nothingface0, @rappoccio, @antoniovilela, @davidlange6, @tjavaid, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @JanFSchulte, @fabiocos, @fioriNTU, @Martin-Grunewald, @mtosi, @cericeci, @Fedespring, @rociovilar, @arossi83, @HuguesBrun, @sroychow, @idebruyn, @jandrea, @missirol, @mmusich, @VourMa, @jhgoh, @VinInn, @trocino this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Apr 29, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c56e70/39155/summary.html
COMMIT: 9b17e1a
CMSSW: CMSSW_14_1_X_2024-04-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44868/39155/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
24834.78 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 2 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 63 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3433373
  • DQMHistoTests: Total failures: 137
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3433216
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 120633.12000000001 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): 9634.955 KiB HLT/EGM
  • DQMHistoSizes: changed ( 23234.0,... ): 10470.565 KiB HLT/EGM
  • Checked 206 log files, 170 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@swagata87
Copy link
Contributor

type egamma, tracking

@mmusich
Copy link
Contributor Author

mmusich commented May 7, 2024

@cms-sw/dqm-l2 this PR has been sitting idle for a week. Can you clarify plans for review and integration?
Thank you.

@tjavaid
Copy link

tjavaid commented May 7, 2024

+1

@mmusich
Copy link
Contributor Author

mmusich commented May 9, 2024

@cms-sw/orp-l2 is there is anything outstanding with this PR, can it be merged?
We'd like to have the backport (#44917) at Tier0 soon for HLT monitoring purposes.

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 573c4cd into cms-sw:master May 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants