Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first release of TICLv5 #44785

Merged
merged 16 commits into from
Jun 12, 2024
Merged

first release of TICLv5 #44785

merged 16 commits into from
Jun 12, 2024

Conversation

felicepantaleo
Copy link
Contributor

PR description:

This PR introduces a preliminary version 5 of the TICL framework. It does not replace TICL v4 in release yet.
It features:

  • A MultiVectorManager to handle transparently more collections of the same type as if it was only one. This is very useful when consuming the results coming from more iterations or linking algorithms
  • Move HGCAL time to local time.
  • Improved TICLCandidate reconstruction and treatment of timing information from MTD, hence improving the matching with tracks.
  • Created a process modifier for ticl_v5 that replaces ticl_v3
  • Split CLUE3D parameters in different areas of the detector
  • Tuning of CLUE3D parameters
  • Introduced plug-in system for trackster-trackster linking
  • Introduced new skeletons trackster-trackster linking algorithm
  • Introduced FastJet trackster-trackster linking
  • Introduced Passthrough trackster-trackster linking
  • Introduced MTD information SoA
  • Introduced local time in MC truth information for SimTracksters and SimTICLCandidate
  • Introduced TICL Graph for holding connections between tracksters needed for upcoming GNN and Leiden algorithms
  • Removed CLUE3DLow step
  • Removed TICL v3.
  • Removed Multiclusters

More info at https://indico.cern.ch/event/1394609/#8-hgcal

PR validation:

Executed several phase 2 workflows with and without the process modifier and verified the TICL validation.

Preliminary performance plots coming soon.

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Apr 19, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 19, 2024 •
edited
Loading

cms-bot internal usage

@felicepantaleo
Copy link
Contributor Author

@AuroraPerego @waredjeb

@cms-sw/hgcal-dpg-l2 @cms-sw/pf-l2

@felicepantaleo
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44785/40021

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @felicepantaleo for master.

It involves the following packages:

  • CommonTools/RecoAlgos (reconstruction)
  • Configuration/EventContent (operations)
  • Configuration/ProcessModifiers (operations)
  • Configuration/PyReleaseValidation (upgrade, pdmv)
  • DataFormats/CaloRecHit (reconstruction)
  • DataFormats/HGCalReco (upgrade, reconstruction)
  • DataFormats/TrackReco (reconstruction)
  • Fireworks/Calo (visualization)
  • HLTrigger/Configuration (hlt)
  • RecoHGCal/Configuration (upgrade, reconstruction)
  • RecoHGCal/TICL (upgrade, reconstruction)
  • RecoLocalCalo/HGCalRecAlgos (upgrade, reconstruction)
  • RecoLocalCalo/HGCalRecProducers (upgrade, reconstruction)
  • RecoMTD/Configuration (upgrade, reconstruction)
  • RecoMTD/TrackExtender (upgrade, reconstruction)
  • RecoParticleFlow/PFClusterProducer (reconstruction)
  • SimCalorimetry/HGCalAssociatorProducers (simulation, upgrade)
  • TrackingTools/Configuration (reconstruction)
  • TrackingTools/PatternTools (reconstruction)
  • Validation/Configuration (dqm, simulation)
  • Validation/HGCalValidation (dqm)

@davidlange6, @Dr15Jones, @civanch, @AdrianoDee, @rvenditti, @srimanob, @miquork, @mmusich, @alja, @mandrenguyen, @mdhildreth, @nothingface0, @antoniovilela, @subirsarkar, @syuvivida, @makortel, @jfernan2, @antoniovagnerini, @tjavaid, @fabiocos, @sunilUIET, @Martin-Grunewald, @rappoccio can you please review it and eventually sign? Thanks.
@ahinzmann, @cericeci, @argiro, @HuguesBrun, @forthommel, @apsallid, @sameasy, @pfs, @jdolen, @jhgoh, @mmusich, @trocino, @gkasieczka, @slomeo, @alja, @cseez, @abbiendi, @mmarionncern, @VourMa, @bsunanda, @lecriste, @silviodonato, @gpetruc, @GiacomoSguazzoni, @mtosi, @lgray, @Fedespring, @sobhatta, @missirol, @makortel, @dgulhan, @thomreis, @JanFSchulte, @bellan, @andrea21z, @fabiocos, @youyingli, @SohamBhattacharya, @Martin-Grunewald, @VinInn, @CeliaFernandez, @seemasharmafnal, @hatakeyamak, @ReyerBand, @wang0jin, @rovere, @edjtscott, @rchatter, @vandreev11, @rappoccio, @sethzenz this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@rovere
Copy link
Contributor

rovere commented Apr 19, 2024

@felicepantaleo I think a bit of history cleanup would be nice.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: HeaderConsistency UnitTests RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ea18a/38967/summary.html
COMMIT: 57b897d
CMSSW: CMSSW_14_1_X_2024-04-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44785/38967/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 22 errors in the following unit tests:

---> test TestConfigDP_1 had ERRORS
---> test TestConfigDP_5 had ERRORS
---> test TestConfigDP_10 had ERRORS
and more ...

RelVals

  • 4.534.53_RunPhoton2012B/step2_RunPhoton2012B.log
  • 4.224.22_RunCosmics2011A/step2_RunCosmics2011A.log
  • 5.15.1_TTbarFS/step1_TTbarFS.log
Expand to see more relval errors ...

RelVals-INPUT

  • 4.174.17_RunMinBias2011A/step2_RunMinBias2011A.log
  • 4.224.22_RunCosmics2011A/step2_RunCosmics2011A.log
  • 4.264.26_ZMuSkim2011A/step2_ZMuSkim2011A.log
Expand to see more relval errors ...

AddOn Tests

[fastsim:1] cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi  --conditions auto:run1_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - elapsed time: 1 sec (ended on Fri Apr 19 18:39:06 2024) - exit: 256

[fastsim1:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - elapsed time: 1 sec (ended on Fri Apr 19 18:39:08 2024) - exit: 256

[fastsim2:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - elapsed time: 1 sec (ended on Fri Apr 19 18:39:13 2024) - exit: 256
Expand to see more addon errors ...

makortel
makortel reviewed Apr 19, 2024
View reviewed changes
Copy link
Contributor

@makortel makortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A cursory look

DataFormats/HGCalReco/BuildFile.xml Outdated Show resolved Hide resolved
DataFormats/HGCalReco/interface/TICLCandidate.h Outdated Show resolved Hide resolved
DataFormats/HGCalReco/interface/Trackster.h Show resolved Hide resolved
DataFormats/HGCalReco/src/classes_def.xml Outdated Show resolved Hide resolved
DataFormats/HGCalReco/src/classes_def.xml Outdated Show resolved Hide resolved
Validation/HGCalValidation/interface/HGCalValidator.h Outdated Show resolved Hide resolved
Validation/HGCalValidation/src/TICLCandidateValidator.cc Outdated Show resolved Hide resolved
TrackingTools/PatternTools/src/classes_def.xml Outdated Show resolved Hide resolved
RecoHGCal/TICL/plugins/TracksterLinksProducer.cc Outdated Show resolved Hide resolved
RecoHGCal/TICL/plugins/TracksterLinkingbyFastJet.h Outdated Show resolved Hide resolved
@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ea18a/39763/summary.html
COMMIT: bdf142f
CMSSW: CMSSW_14_1_X_2024-06-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44785/39763/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 14 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338974
  • DQMHistoTests: Total failures: 289
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338665
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 450.94800000000004 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 23234.0,... ): 75.158 KiB HGCAL/HGCalValidator
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Jun 7, 2024

+1

@srimanob
Copy link
Contributor

srimanob commented Jun 7, 2024

+Upgrade

@mmusich
Copy link
Contributor

mmusich commented Jun 7, 2024

+hlt

@cmsbuild cmsbuild mentioned this pull request Jun 8, 2024
Merged
@felicepantaleo
Copy link
Contributor Author

@cms-sw/operations-l2 @cms-sw/orp-l2 could you please merge this? I won't be able to attend the ORP meeting today.

@antoniovilela
Copy link
Contributor

+operations

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a40029d into cms-sw:master Jun 12, 2024
12 checks passed
This was referenced Jun 12, 2024
Merged
Merged
@smuzaffar smuzaffar mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AuroraPerego AuroraPerego AuroraPerego left review comments

@mandrenguyen mandrenguyen mandrenguyen left review comments

@srimanob srimanob srimanob left review comments

@rovere rovere rovere left review comments

@makortel makortel makortel left review comments

Assignees
No one assigned
Labels
code-checks-approved core-approved dqm-approved fully-signed hlt-approved operations-approved orp-approved pdmv-approved reconstruction-approved requires-external simulation-approved tests-approved upgrade-approved visualization-approved
Projects
None yet
Milestone
CMSSW_14_1_X
Development

Successfully merging this pull request may close these issues.