Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrackingMonitoringClient: fix axis labels for fake rate vs OnlineLumi, LS and PU #44832

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 24, 2024

PR description:

Trivial bug-fix, noticed when looking at the recent (2024C) runs https://tinyurl.com/26yk5toj in the HLTMonitor DQM. These plots have been introduced from #42547.

PR validation:

None

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Will be backported to CMSSW_14_0_X

@mmusich mmusich changed the title TrackingMonitoringClient: fix axis labels for fake rate vs OnlineLUmi, LS and PU TrackingMonitoringClient: fix axis labels for fake rate vs OnlineLumi, LS and PU Apr 24, 2024
@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Apr 24, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 24, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Apr 24, 2024

type bug-fix

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44832/40076

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQMOffline/Trigger (dqm)

@nothingface0, @cmsbuild, @antoniovagnerini, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@mtosi, @missirol, @HuguesBrun, @trocino, @Fedespring, @rociovilar, @jhgoh, @cericeci this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Apr 24, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75405b/39053/summary.html
COMMIT: 694d2bf
CMSSW: CMSSW_14_1_X_2024-04-23-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44832/39053/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 26 lines to the logs
  • Reco comparison results: 46 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3319852
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3319829
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Apr 29, 2024

@cms-sw/dqm-l2 please sign this straightforward fix

@tjavaid
Copy link

tjavaid commented Apr 29, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@francescobrivio
Copy link
Contributor

@cms-sw/orp-l2 this RP is fully signed (except ORP-signature) and it's in any case a trivial fix in a plot label.
The backport is also ready to be integrated in the next patch release.

Thanks!
Francesco as ORM

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b405e18 into cms-sw:master Apr 29, 2024
11 checks passed
@mmusich mmusich deleted the mm_fix_TrackingMonitoring_Client_cfff branch April 29, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants