Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added efficiencies of matched and unmatched tracks (between HLT and offline) vs LS, vs online lumi and vs PU #42547

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

acmbulla
Copy link
Contributor

PR description:

Added histograms vs lumisection, vs online lumi & vs PU to monitor the efficiency of matched and unmatched tracks from HLT to offline. Histograms are filled in the pt and dxy plateau, as the other efficiencies.

PR validation:

Run raw2digi, L1Reco, reconstruction, dqmoffline and DQMoutput steps, on HLTMonitoring PD, run 370790.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42547/36561

  • This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42547/36562

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @acmbulla (Andrea Bulla) for master.

It involves the following packages:

  • DQM/TrackingMonitorSource (dqm)
  • DQMOffline/Trigger (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @VourMa, @sroychow, @JanFSchulte, @jhgoh, @VinInn, @missirol, @HuguesBrun, @Fedespring, @threus, @jandrea, @mtosi, @idebruyn, @mmusich, @rociovilar, @trocino, @cericeci, @fioriNTU this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Aug 11, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8e2f7/34234/summary.html
COMMIT: 85bb403
CMSSW: CMSSW_13_3_X_2023-08-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42547/34234/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 14 lines from the logs
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3150947
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 4
  • DQMHistoTests: Total successes: 3150918
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 55.254 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 12434.0,... ): 27.627 KiB HLT/Tracking
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Aug 11, 2023

test parameters:

  • workflows = 141.041, 141.042, 141.046

@mmusich
Copy link
Contributor

mmusich commented Aug 11, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8e2f7/34244/summary.html
COMMIT: 85bb403
CMSSW: CMSSW_13_3_X_2023-08-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42547/34244/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 23 lines from the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3416257
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 8
  • DQMHistoTests: Total successes: 3416224
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 110.508 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 141.041,... ): 27.627 KiB HLT/Tracking
  • Checked 219 log files, 171 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants