Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.2.X] Added efficiencies of matched and unmatched tracks (between HLT and offline) vs LS, vs online lumi and vs PU #42593

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 17, 2023

backport of #42547

PR description:

Added histograms vs lumisection, vs online lumi & vs PU to monitor the efficiency of matched and unmatched tracks from HLT to offline. Histograms are filled in the pt and dxy plateau, as the other efficiencies.

PR validation:

Run raw2digi, L1Reco, reconstruction, dqmoffline and DQMoutput steps, on HLTMonitoring PD, run 370790.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #42547 in case we get to have a HLTMonitor PD for ppRef or HI data-taking. (N.B. track collection names etc. will need to be customized, once a finalized HLT menu is available).

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 17, 2023

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_2_X.

It involves the following packages:

  • DQM/TrackingMonitorSource (dqm)
  • DQMOffline/Trigger (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @VourMa, @sroychow, @JanFSchulte, @jhgoh, @VinInn, @missirol, @HuguesBrun, @Fedespring, @threus, @jandrea, @mtosi, @idebruyn, @mmusich, @rociovilar, @trocino, @cericeci, @fioriNTU this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9b4e7/34348/summary.html
COMMIT: 616a54f
CMSSW: CMSSW_13_2_X_2023-08-17-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42593/34348/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 9 lines to the logs
  • Reco comparison results: 18 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196338
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 4
  • DQMHistoTests: Total successes: 3196300
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 55.254 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 12434.0,... ): 27.627 KiB HLT/Tracking
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@emanueleusai
Copy link
Member

+1

1 similar comment
@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 40c74d3 into cms-sw:CMSSW_13_2_X Aug 23, 2023
@mmusich mmusich deleted the addOnlineVsOfflineEffAndFakeVsPU-Lumi_13_2_X branch August 23, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants