Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved creating SiPixelTemplateStore from DB to an ESProducer [13_2] #42644

Merged

Conversation

Dr15Jones
Copy link
Contributor

PR description:

All DB construction was switched to using EventSetup. Cases using reading from files were kept local to module.
The new ESProducer was added as a Task to all needed Sequences.

PR validation:

Code compiles.

backport of #42514 and #42597

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 23, 2023

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_13_2_X.

It involves the following packages:

  • Alignment/OfflineValidation (alca)
  • CalibTracker/SiPixelLorentzAngle (alca)
  • Calibration/TkAlCaRecoProducers (alca)
  • CondFormats/SiPixelTransient (db, reconstruction)
  • DQM/SiPixelPhase1Config (dqm)
  • DQM/SiPixelPhase1Track (dqm)
  • DQMOffline/Trigger (dqm)
  • FastSimulation/Configuration (fastsim)
  • FastSimulation/TrackingRecHitProducer (fastsim)
  • HLTrigger/Configuration (hlt)
  • RecoHI/HiTracking (reconstruction)
  • RecoLocalTracker/SiPixelRecHits (reconstruction)
  • RecoTracker/FinalTrackSelectors (reconstruction)
  • RecoTracker/TrackProducer (reconstruction)
  • RecoTracker/TransientTrackingRecHit (reconstruction)

@perrotta, @Martin-Grunewald, @ssekmen, @tvami, @nothingface0, @civanch, @emanueleusai, @consuegs, @mdhildreth, @mandrenguyen, @cmsbuild, @missirol, @saumyaphor4252, @clacaputo, @syuvivida, @sbein, @pmandrik, @tjavaid, @micsucmed, @francescobrivio, @rvenditti can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @Martin-Grunewald, @Fedespring, @tlampen, @threus, @mmusich, @seemasharmafnal, @silviodonato, @JanFSchulte, @jhgoh, @missirol, @yenjie, @cericeci, @ferencek, @trocino, @yetkinyilmaz, @fioriNTU, @sroychow, @GiacomoSguazzoni, @rovere, @VinInn, @mroguljic, @tocheng, @jandrea, @idebruyn, @ebrondol, @mtosi, @dgulhan, @arossi83, @HuguesBrun, @adewit, @mandrenguyen, @jazzitup, @dkotlins, @kurtejung, @gpetruc, @matt-komm, @rociovilar, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Aug 23, 2023

this branch has conflicts to be resolved.

All DB construction was switched to using EventSetup. Cases using
reading from files were kept local to module.
The new ESProducer was added as a Task to all needed Sequences.
@Dr15Jones Dr15Jones force-pushed the SiPixelTemplateStoreFromES_13_2 branch from c7a8214 to 1e1d2a0 Compare August 23, 2023 14:15
@cmsbuild
Copy link
Contributor

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67adef/34452/summary.html
COMMIT: 1e1d2a0
CMSSW: CMSSW_13_2_X_2023-08-23-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42644/34452/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67adef/34452/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67adef/34452/git-merge-result

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196338
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 4
  • DQMHistoTests: Total successes: 3196309
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 55.254 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 12434.0,... ): 27.627 KiB HLT/Tracking
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

+hlt

(This update will require the 'parsing' of the next CMSSW_13_2_X release into ConfDB, in order to add the new ESProducer to the HLT menus in the db, I think.)

@missirol
Copy link
Contributor

backport of #42514
backport of #42597

Copy link
Contributor

@perrotta perrotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The three backports in 13_2_X, 13_1_X and 13_0_X are identical, and all verbatim backports of the combination of #42514 and #42597. Therefore the same comments made here are also valid for #42647 and #42648

The use of a Task at this time causes to much disruption. Moving
ES modules to Tasks should wait till a dedicated campaign.
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67adef/34528/summary.html
COMMIT: 7e32389
CMSSW: CMSSW_13_2_X_2023-08-29-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42644/34528/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 11 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3197913
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3197888
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@mmusich
Copy link
Contributor

mmusich commented Aug 29, 2023

+hlt

@perrotta
Copy link
Contributor

+alca

@perrotta
Copy link
Contributor

+db

@emanueleusai
Copy link
Member

+1

@civanch
Copy link
Contributor

civanch commented Aug 31, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @dpiparo, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f813a1a into cms-sw:CMSSW_13_2_X Sep 1, 2023
@Dr15Jones Dr15Jones deleted the SiPixelTemplateStoreFromES_13_2 branch October 6, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants