-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved creating SiPixelTemplateStore from DB to an ESProducer [13_2] #42644
Moved creating SiPixelTemplateStore from DB to an ESProducer [13_2] #42644
Conversation
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_13_2_X. It involves the following packages:
@perrotta, @Martin-Grunewald, @ssekmen, @tvami, @nothingface0, @civanch, @emanueleusai, @consuegs, @mdhildreth, @mandrenguyen, @cmsbuild, @missirol, @saumyaphor4252, @clacaputo, @syuvivida, @sbein, @pmandrik, @tjavaid, @micsucmed, @francescobrivio, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
this branch has conflicts to be resolved. |
All DB construction was switched to using EventSetup. Cases using reading from files were kept local to module. The new ESProducer was added as a Task to all needed Sequences.
c7a8214
to
1e1d2a0
Compare
Pull request #42644 was updated. @perrotta, @Martin-Grunewald, @ssekmen, @tvami, @nothingface0, @civanch, @emanueleusai, @consuegs, @mdhildreth, @mandrenguyen, @cmsbuild, @missirol, @saumyaphor4252, @clacaputo, @syuvivida, @sbein, @pmandrik, @tjavaid, @micsucmed, @francescobrivio, @rvenditti can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67adef/34452/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
+hlt (This update will require the 'parsing' of the next CMSSW_13_2_X release into ConfDB, in order to add the new ESProducer to the HLT menus in the db, I think.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calibration/TkAlCaRecoProducers/python/ALCARECOPromptCalibProdSiPixelLorentzAngleMCS_cff.py
Outdated
Show resolved
Hide resolved
The use of a Task at this time causes to much disruption. Moving ES modules to Tasks should wait till a dedicated campaign.
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67adef/34528/summary.html Comparison SummarySummary:
|
+1 |
+hlt |
+alca |
+db |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @dpiparo, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
All DB construction was switched to using EventSetup. Cases using reading from files were kept local to module.
The new ESProducer was added as a Task to all needed Sequences.
PR validation:
Code compiles.
backport of #42514 and #42597