-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved creating SiPixelTemplateStore from DB to an ESProducer [13_1] #42647
Moved creating SiPixelTemplateStore from DB to an ESProducer [13_1] #42647
Conversation
All DB construction was switched to using EventSetup. Cases using reading from files were kept local to module. The new ESProducer was added as a Task to all needed Sequences.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_13_1_X. It involves the following packages:
@perrotta, @Martin-Grunewald, @ssekmen, @tvami, @nothingface0, @civanch, @emanueleusai, @consuegs, @mdhildreth, @mandrenguyen, @cmsbuild, @missirol, @saumyaphor4252, @clacaputo, @syuvivida, @sbein, @pmandrik, @tjavaid, @micsucmed, @francescobrivio, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59226c/34454/summary.html Comparison SummarySummary:
|
+hlt |
The use of a Task at this time causes to much disruption. Moving ES modules to Tasks should wait till a dedicated campaign.
e5b3952
to
0a6ee43
Compare
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59226c/34530/summary.html Comparison SummarySummary:
|
+1 |
+hlt |
+alca |
+db |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @dpiparo, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
All DB construction was switched to using EventSetup. Cases using reading from files were kept local to module.
The new ESProducer was added as a Task to all needed Sequences.
PR validation:
Code compiles.
backport of #42514 and #42597